feat(insights): epic branch for all Insights features by dkoo · Pull Request #315 · Automattic/newspack-workspace

dkoo · 2026-06-15T17:51:55Z

All Submissions:

Have you followed the Newspack Contributing guidelines?
Does your code follow the WordPress coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Epic branch for all Newspack Insights features. This is so we can quickly create and merge PRs for Insights without going through our usual human code review process, while also not affecting production code on main. This branch will be kept up-to-date with main so it remains in a state where it can be cleanly merged once we've performed enough QA to consider Insights production-ready.

Companion PR to https://github.com/Automattic/newspack-manager-admin/pull/462. Both branches are required for Insights to work end-to-end.

How to test the changes in this Pull Request:

TK.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully run tests with your changes locally?

…cribers feat(insights): subscribers tab (NPPD-1616)

feat(insights): gates tab phase 1 (NPPD-1604)

feat(insights): land Donors + Gates tabs on main (NPPD-1617, NPPD-1604)

…igence-ga4-client-into-newspack-plugin feat(insights): extract GA4 Data API client (NPPD-1647)

…ment-metric-orchestrators-with-ga4-dispatch feat(insights): audience + engagement metric orchestrators (NPPD-1648)

…ce-and-engagement-ui-implementation feat(insights): audience and engagement UI with fixture mode (NPPD-1649)

…y-and-review-fixes fix(insights): re-land orphaned wizard-chrome a11y + review fixes (NPPD-1602)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

* feat(insights): add BigQuery proxy client and Gates_Metric injection seam * fix(insights): normalize proxy client dates to UTC and modernize JSON validation * feat(insights): wire Section 1 scorecards to BigQuery proxy * fix(insights): reject non-integer values for count metrics in proxy helper * feat(insights): wire Section 2 regwall conversion to BigQuery proxy * feat(insights): add Woo_Order_Resolver for paywall completion joins * chore(insights): harden Woo_Order_Resolver tests and docs * feat(insights): wire Section 3 paywall conversion + revenue * perf(insights): memoize paywall-direct join to avoid duplicate proxy calls * feat(insights): wire Section 4 funnel and exposures distribution * feat(insights): wire Section 5 performance-by-gate with title enrichment * feat(insights): compute tab_pending from metric outcomes * docs(insights): clarify is_window_all_pending semantics for unrecognized payloads * feat(insights): log BigQuery proxy failures via newspack_log action

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Phase 1 UI scaffold for the Insights Prompts tab: seven sections, tab-local viz (funnel, distribution, three sortable performance tables), REST endpoint, and an orchestrator returning pending:true placeholders. Mirrors the Tab 4 (Gates) Phase 1 pattern; Phase 2 swaps the orchestrator stubs to BigQuery dispatch without touching the UI or method signatures. Part of NPPD-1607. Phase 2 (BigQuery wiring): NPPD-1682. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Port the applicable Tab 4 (Gates) optimizations from #267 to the Prompts tab: the SVG trapezoid conversion funnel (responsive side/compact layouts, clamped drop-off, contrast-aware in-band counts, '% of {top stage}' + 'drop-off' labels), and the shared __table-num / __table-na chrome so numeric cells right-align (the #267 specificity fix) and non-applicable cells render a muted em-dash. The state-model / error-empty-populated changes from #267 are Phase 2 (NPPD-1682) and are intentionally not adopted here. Part of NPPD-1607. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The Performance by prompt table now renders only the top 10 rows (by the active sort) with a 'See more (N)' / 'See less' toggle that reveals the rest, instead of a flat 50-row list. Implemented as an optional initialRowLimit on the tab-local SortableTable primitive, so the intent and placement tables are unaffected. No orchestrator change — the backend still caps at 50; the UI collapses to 10. Part of NPPD-1607. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Replace the donation_attempts / subscription_attempts columns on the Performance by prompt table with four conversion columns — donation_conversions, donation_conversion_rate, subscription_conversions, subscription_conversion_rate — so the per-prompt breakdown reports Woo-completed outcomes rather than engagement intent. Aligns with the Gates v1.1 decision (NPPD-1684); locks the final column set before Phase 2 (NPPD-1682) wires the BigQuery + Woo join. Phase 1 values remain placeholder zeros. Also brings the Tab 5 spec into the monorepo docs (specs/prompts.md) and updates the spec + formula docs to describe the conversion columns and resolve open question #2. Part of NPPD-1607. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…tion core) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…al-registered-users-on-the-audience-tab feat(insights): registered readers on the Audience tab (NPPD-1733)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(insights): add timestamp-window Source_Matcher (Woo-join remediation core) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(insights): deterministic Source_Matcher + align test conventions Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…d-ts-test-files-not-collected-by-npm-test test(insights): rename format.test.js back to .ts (NPPD-1683)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…ability-gate fix(insights): gate Donors tab on donation activity in last 365 days

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…pine feat(insights): tier-1 publisher feedback spine (NPPD-1728)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…ayers feat(insights): tier-2 feedback modal (NPPD-1728)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…-pdf-tweaks fix(insights): prompt cards full width, landscape PDF, relabel export

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rder-dates feat(insights): first-conversion-date storage helpers for Tab 3

Mirror the Paid empty-state pattern (NPPD-1694) for the Gates Free (regwall) section. Detection distinguishes three cases, not two: hub count fields absent (graceful degradation to today's percentages), present-but-zero impressions (no_opportunity), and zero registrations (no_conversions). An absent field is not a zero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Code-review follow-up: the fields-absent envelope guard hand-built the Influenced operand instead of calling get_regwall_conversion_influenced_7d, so its "end-to-end through the public method" claim overstated coverage. Drive both regwall methods from a per-query mock so the Influenced rate_key and null-count path are genuinely exercised. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…ymetricsection-pattern-to-gates-free feat(insights): Gates Free section empty states (NPPD-1702)

…PPD-1742) Apply the empty-state pattern to the Conversion Journeys subscription and donation legs. A per-leg visibility gate hides a conversion endpoint when the publisher doesn't run that reader-revenue stream (config matrix); configured- but-quiet legs get funnel-shaped no_opportunity / no_conversions treatments. The registration leg is left as-is (NPPD-1743). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…PPD-1742) Code-review follow-up: the subscription/donation no_conversions note fired on conversion===0 alone, so a leg with registered readers but zero prior-stage base (e.g. no prompt shown) rendered "{0} saw a prompt, but none converted" next to a funnel showing readers entering — self-contradicting, and counter to the ticket's "prior stage HAS a base" definition. Guard on priorStage > 0; that case now falls through to the normal funnel. Adds an edge-case test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…D-1742) PHPCS (workspace-root standard, stricter than the plugin lint) flagged the $donation_leg_configured property's @var-only docblock as missing a short description. Add one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…-journeys-empty-states-config-matrix feat(insights): Conversion Journeys config matrix + leg empty states (NPPD-1742)

kmwilkerson and others added 30 commits June 15, 2026 11:43

Merge pull request #217 from Automattic/nppd-1616-insights-tab-6-subs…

31041f3

…cribers feat(insights): subscribers tab (NPPD-1616)

Merge pull request #229 from Automattic/nppd-1604-insights-tab-4-gates

bb2f7a8

feat(insights): gates tab phase 1 (NPPD-1604)

Merge pull request #243 from Automattic/nppd-1617-insights-tab-7-donors

cc1a733

feat(insights): land Donors + Gates tabs on main (NPPD-1617, NPPD-1604)

Merge pull request #238 from Automattic/nppd-1647-extract-gate-intell…

75e94c8

…igence-ga4-client-into-newspack-plugin feat(insights): extract GA4 Data API client (NPPD-1647)

Merge pull request #239 from Automattic/nppd-1648-audience-and-engage…

f4ab9ab

…ment-metric-orchestrators-with-ga4-dispatch feat(insights): audience + engagement metric orchestrators (NPPD-1648)

Merge pull request #240 from Automattic/nppd-1649-tabs-1-and-2-audien…

6fb7255

…ce-and-engagement-ui-implementation feat(insights): audience and engagement UI with fixture mode (NPPD-1649)

Merge pull request #244 from Automattic/nppd-1602-insights-chrome-a11…

76f4a41

…y-and-review-fixes fix(insights): re-land orphaned wizard-chrome a11y + review fixes (NPPD-1602)

feat(insights): GAM API reporting client via SOAP (NPPD-1662) (#256)

b253b36

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): GA4 client + orchestrator review fixes (NPPD-1669) (#257)

19ac3a3

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

feat(insights): advertising metric orchestrator with GAM dispatch (#259)

c175416

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

feat(insights): advertising UI implementation (#262)

eb8c158

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): page_title/author dims + audience/engagement UX fixes

a6788cd

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): populate newsletter reader-segment card on live data

acc7b05

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

test(insights): cover newsletter reader-segment card key matching

7e20c0d

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

refactor(insights): unify tab loading with a shared spinner frame

c3c65c0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): address review - campaign rows, not-set authors, dedup

f121670

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

style(insights): capitalize meaningful-filter docblock for PHPCS

20305e2

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): distinguish error/empty/populated states in Gates

2b15253

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

feat(insights): SVG trapezoid conversion funnel viz

d5891e0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): align Gates performance-table fields with orchestrator

f560004

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chore(insights): gates fixture-mode payload for smoke testing

e3d01e7

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

style(insights): split gates fixture assoc array per PHPCS

3ac871d

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): gates deltas off-compare, malformed=error, cleanups

9c9b98e

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): soften funnel, clearer labels, right-align tables

c3a380c

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): restore primary-500 funnel fill (less muted)

16e4ed9

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

dkoo and others added 21 commits June 18, 2026 14:10

feat(insights): add timestamp-window Source_Matcher (Woo-join remedia…

ba97d72

…tion core) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Merge pull request #357 from Automattic/nppd-1733-insights-report-tot…

d15d454

…al-registered-users-on-the-audience-tab feat(insights): registered readers on the Audience tab (NPPD-1733)

test(insights): rename format.test.js back to .ts (NPPD-1683)

4abfa39

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(insights): deterministic Source_Matcher + align test conventions

d823f7b

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Merge pull request #363 from Automattic/nppd-1683-insights-tab-tsx-an…

e5181e2

…d-ts-test-files-not-collected-by-npm-test test(insights): rename format.test.js back to .ts (NPPD-1683)

fix(insights): gate Donors tab on donation activity in last 365 days

fd6b0f9

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Merge pull request #364 from Automattic/nppd-1737-insights-donors-cap…

c78b600

…ability-gate fix(insights): gate Donors tab on donation activity in last 365 days

feat(insights): tier-1 publisher feedback spine (NPPD-1728)

33e4e96

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Merge pull request #365 from Automattic/nppd-1728-insights-feedback-s…

61df2e9

…pine feat(insights): tier-1 publisher feedback spine (NPPD-1728)

feat(insights): tier-2 freeform modal + ship-callback (NPPD-1728)

60f790a

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Merge pull request #366 from Automattic/nppd-1728-insights-feedback-l…

abcad03

…ayers feat(insights): tier-2 feedback modal (NPPD-1728)

fix(insights): prompt cards full width, landscape PDF, relabel export

f9eaf8d

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

test(insights): update PromptsTab snapshot for cols-3 grids

7930f70

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Merge pull request #367 from Automattic/fix/insights-prompt-cards-and…

50f0761

…-pdf-tweaks fix(insights): prompt cards full width, landscape PDF, relabel export

feat(insights): first-subscription-date storage helper for Tab 3

134309b

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat(insights): first-donation-date storage helper for Tab 3

fcc51a1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix(insights): cast legacy customer_user + document empty-date guard

5b6aeb9

docs(insights): note lexical MIN assumption on subscription date helpers

6068930

Merge pull request #369 from Automattic/feat/insights-storage-first-o…

78922b2

…rder-dates feat(insights): first-conversion-date storage helpers for Tab 3

Merge branch 'main' into feat/insights-rsm

d8eae04

dkoo assigned dkoo and kmwilkerson Jun 19, 2026

kmwilkerson and others added 7 commits June 19, 2026 15:57

Merge pull request #370 from Automattic/nppd-1702-insights-apply-empt…

2b6dfa8

…ymetricsection-pattern-to-gates-free feat(insights): Gates Free section empty states (NPPD-1702)

Merge pull request #371 from Automattic/nppd-1742-insights-conversion…

f07616e

…-journeys-empty-states-config-matrix feat(insights): Conversion Journeys config matrix + leg empty states (NPPD-1742)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(insights): epic branch for all Insights features#315

feat(insights): epic branch for all Insights features#315
dkoo wants to merge 220 commits into
mainfrom
feat/insights-rsm

dkoo commented Jun 15, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dkoo commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkoo commented Jun 15, 2026 •

edited

Loading