Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence Jest warnings about punycode module deprecation #912

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Silence Jest warnings about punycode module deprecation #912

merged 2 commits into from
Feb 13, 2025

Conversation

fredrikekelund
Copy link
Contributor

@fredrikekelund fredrikekelund commented Feb 10, 2025 •
edited
Loading

Related issues

Proposed Changes

Silence the punycode deprecation warnings printed in Node 22 when running npm test (see issue description for more details).

Testing Instructions

  1. Run npm test
  2. Ensure that no deprecation warnings about the punycode are printed

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@fredrikekelund fredrikekelund requested a review from a team February 10, 2025 14:17
@fredrikekelund fredrikekelund self-assigned this Feb 10, 2025
wojtekn
wojtekn approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no warning related to punycode when I run npm test.

@fredrikekelund fredrikekelund merged commit 4dc84a3 into trunk Feb 13, 2025
8 checks passed
@fredrikekelund fredrikekelund deleted the f26d/silence-punycode-deprecation-warnings branch February 13, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtekn wojtekn wojtekn approved these changes

Assignees

@fredrikekelund fredrikekelund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekelund @wojtekn