Replace _s by theme-slug for text_domain value in phpcs ruleset file

[truongwp]

No description provided.

[truongwp]

Related #54

[jrfnl]

Related ? You mean duplicate, I presume ?

[grappler]

@jrfnl #56 is a PR and #54 is an issue.

[jrfnl]

@grappler Thanks for putting me right.

In that case, shouldn't it be: Fixes #54 ? 👍

[truongwp]

@jrfnl Like you said in the issue:

The _s in the below snippet is not being replaced by the generator at this time.
Once WPCS 0.12.0 comes out, a second customization will be added, which will also take _s as an property value, so let's keep this issue open until this is handled correctly.

So I'm not sure this will be merged or wait for WPCS 0.12.0, so I am not sure it should be "Fixes"

[jrfnl]

@truongwp Partially fixes maybe ?
Thanks for creating the PR!

[davidakennedy]

Thanks for the pull request @truongwp! It may be better to go ahead and wait for WPCS 0.12.0 so everything can be fixed at once.

[MehbubRashid]

Hi @davidakennedy this problem still existing in 2021