update: subscription onboarding to use WP components #10907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
commented
Jul 4, 2025
| @@ -87,14 +89,7 @@ const SubscriptionProductOnboardingModalContent = ( { | |||
| 'woocommerce-payments' | |||
| ), | |||
| { | |||
| a: ( | |||
| // eslint-disable-next-line jsx-a11y/anchor-has-content | |||
| <a | |||
There was a problem hiding this comment.
Modifying to the external link component, since this opens in a new window. The external link component provides a visual hint that the link will open in a new page, and it ensures a11y compatibility by adding the "(opens in a new tab)" text.
frosso
commented
Jul 4, 2025
| @@ -10,6 +10,7 @@ | |||
| } | |||
|
|
|||
| .components-modal__content { | |||
| padding-top: 0; | |||
There was a problem hiding this comment.
Fixing the top spacing on the dialog itself - see before & after:
|
Size Change: +423 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
rtio
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5124
Changes proposed in this Pull Request
Ensuring that the
subscription-product-onboardingdialog uses the components from the WP installation, rather than the@wordpress/componentsbundled with the plugin's codebase.Testing instructions
Unfortunately, I couldn't find a way to "canonically" test this.
I opted for forcing the dialog to be displayed by manually altering the
includes/subscriptions/class-wc-payments-subscriptions-onboarding-handler.phpfile:npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge