Unbundling payments detail & transactions #10929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
rtio
changed the title
frosso
approved these changes
Jul 15, 2025
| @@ -17,9 +17,29 @@ export const makeWrappedComponent = < | |||
| ) => | |||
| React.forwardRef< | |||
| any, | |||
| ComponentProps< T > & { useBundledComponent?: boolean } | |||
| ComponentProps< T > & { | |||
| useBundledComponent?: boolean; | |||
There was a problem hiding this comment.
With your cleanup, are there existing usages of useBundledComponent in the codebase, or are we planning on using it?
I wonder if we can just remove it 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WOOPMNT-5168
Changes proposed in this Pull Request
Updating the components Transactions (also some updates on Disputes) and Payments to use the WP components that come with the WP installation.
Some pages that use the Card component changed a little due to the newer Card be rounded on the borders. Disputes changes are covered by the new design in Figma (MFTBqaIP0YmS1luyVWmZfW-fi-726_40591), so no worries there.
For transactions, the new Card is rounded in contrast with the old one:
Before
After
For disputes, we're now using the the default 40px height for some components:
Buttons:
Before
After
TextControl
Before
After
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge