Skip to content

Conversation

Abdalsalaam
Copy link
Collaborator

@Abdalsalaam Abdalsalaam commented Aug 18, 2025

Description

  • Fix - Exclude shipping-related admin components when shipping functionality is disabled.

Related issue(s)

WOOSHIP-1535

Steps to reproduce & screenshots/GIFs

  1. Install and configure the current WooCommerce Tax plugin release along with WooCommerce Shipping.
  2. Go to WooCommerce > Status > WooCommerce Tax then you will find Print functionality still
  3. Update the plugin with this branch and re-do the previous step.

Checklist

  • unit tests
  • changelog.txt entry added
  • readme.txt entry added

@Abdalsalaam Abdalsalaam self-assigned this Aug 18, 2025
@Abdalsalaam Abdalsalaam marked this pull request as ready for review August 19, 2025 01:15
@Abdalsalaam Abdalsalaam requested a review from bartech August 20, 2025 10:10
@dustinparker
Copy link
Collaborator

@Abdalsalaam I'm still seeing the WooCommerce Shipping settings on a brand new WP site. These settings should not show if the merchant wasn't "grandfathered in" and doesn't have the WC Shipping plugin installed:

image

@Abdalsalaam
Copy link
Collaborator Author

Abdalsalaam commented Sep 21, 2025

@Abdalsalaam I'm still seeing the WooCommerce Shipping settings on a brand new WP site. These settings should not show if the merchant wasn't "grandfathered in" and doesn't have the WC Shipping plugin installed:
image

I noticed something with new installs connected to a fresh WooCommerce account:

  • Once the site is connected, the option wc_connect_only_tax is set to no. ( I want to check if this value is set by connect server ).
  • From my understanding, this should probably be 1 for new installs/accounts as well.
  • I tested multiple accounts and saw mixed results, so I’m still running more tests to confirm.

In addition, I found that the following banner is added by WooCommerce core, which effectively hides the WooCommerce Tax shipping meta box:
https://github.com/woocommerce/woocommerce/blob/b5640b450b21468a619e57f66298d2409426b635/plugins/woocommerce/client/admin/client/wp-admin-scripts/print-shipping-label-banner/shipping-banner/index.js#L248
image

However, if you install the FedEx plugin first and then enable WC Tax, the shipping features are enabled, and a different banner (added by the WC Tax plugin) is displayed instead:
image

This behavior feels inconsistent. I think we may need to review how new installs are flagged and ensure the banners and the wc_connect_only_tax option align with the intended defaults.

====
note : this PR related to the same issue

@dustinparker
Copy link
Collaborator

Hey @Ferdev! 👋
Would you be able to provide some insight regarding how this should work on new installs? #2879 (comment)

@Ferdev
Copy link
Contributor

Ferdev commented Sep 25, 2025

hey @dustinparker ! yeah, sure, allow me to elaborate. When a new user installs this plugin in their site for the first time, the connect server checks whether or not this is the first time the user installed the plugin in their site. It returns that info to this plugin through the features.first_install flag in the services response. If it is the firs time it's been installed, the shipping part of this plugin shouldn't be loaded, but should allow using the WooCommerce Shipping plugin if it's installed.

Copy link
Collaborator

@dustinparker dustinparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the issue. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants