-
Notifications
You must be signed in to change notification settings - Fork 21
Fix WOOSHIP-1535 - Don't load shipping settings if WC shipping or tax-only is enabled #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
@Abdalsalaam I'm still seeing the WooCommerce Shipping settings on a brand new WP site. These settings should not show if the merchant wasn't "grandfathered in" and doesn't have the WC Shipping plugin installed: ![]() |
I noticed something with new installs connected to a fresh WooCommerce account:
In addition, I found that the following banner is added by WooCommerce core, which effectively hides the WooCommerce Tax shipping meta box: However, if you install the FedEx plugin first and then enable WC Tax, the shipping features are enabled, and a different banner (added by the WC Tax plugin) is displayed instead: This behavior feels inconsistent. I think we may need to review how new installs are flagged and ensure the banners and the ==== |
Hey @Ferdev! 👋 |
hey @dustinparker ! yeah, sure, allow me to elaborate. When a new user installs this plugin in their site for the first time, the connect server checks whether or not this is the first time the user installed the plugin in their site. It returns that info to this plugin through the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixed the issue. LGTM!
Description
Related issue(s)
WOOSHIP-1535
Steps to reproduce & screenshots/GIFs
Checklist
changelog.txt
entry addedreadme.txt
entry added