Skip to content

Conversation

bartech
Copy link
Collaborator

@bartech bartech commented Sep 25, 2025

Description

Unifies how rates are stored. It only use itemized rates. Display tax totals still allow to control how rates are displayed in Cart and Checkout and both options save same tax rates. This allow to remove clearing of tax rates after Display tax totals is changed.

Removes get_combined_tax_rates and generate_combined_tax_rate_name methods.

Prevent saving "State" for VAT tax. VAT is country wide tax.

Related issue(s)

Closes https://linear.app/a8c/issue/WOOSHIP-1580/changing-display-tax-totals-clears-all-tax-rates-when-automated-taxes
Closes https://linear.app/a8c/issue/WOOSHIP-1569/no-vat-calculated-for-two-word-counties-in-lithuania
Closes https://linear.app/a8c/issue/WOOSHIP-1625/fatal-error-in-woocommerce-tax-taxjar-integration-conflict-with-square

Steps to reproduce & screenshots/GIFs

Checklist

  • unit tests
  • changelog.txt entry added
  • readme.txt entry added

@bartech bartech self-assigned this Sep 25, 2025
@bartech bartech marked this pull request as ready for review September 25, 2025 09:43
Copy link
Collaborator

@dustinparker dustinparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to work as expected. I tested upgrading with several different scenarios and the rates are calculated and displayed properly. We just need to merge trunk into the branch and this should be good to go.

Copy link
Collaborator

@iyut iyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartech bartech merged commit 3f53a2f into trunk Oct 8, 2025
9 checks passed
@bartech bartech deleted the refactor-tax-rate-storing branch October 8, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants