-
Notifications
You must be signed in to change notification settings - Fork 21
Refactor tax rate storing #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove storing combined tax rates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything appears to work as expected. I tested upgrading with several different scenarios and the rates are calculated and displayed properly. We just need to merge trunk into the branch and this should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Unifies how rates are stored. It only use itemized rates. Display tax totals still allow to control how rates are displayed in Cart and Checkout and both options save same tax rates. This allow to remove clearing of tax rates after Display tax totals is changed.
Removes
get_combined_tax_rates
andgenerate_combined_tax_rate_name
methods.Prevent saving "State" for VAT tax. VAT is country wide tax.
Related issue(s)
Closes https://linear.app/a8c/issue/WOOSHIP-1580/changing-display-tax-totals-clears-all-tax-rates-when-automated-taxes
Closes https://linear.app/a8c/issue/WOOSHIP-1569/no-vat-calculated-for-two-word-counties-in-lithuania
Closes https://linear.app/a8c/issue/WOOSHIP-1625/fatal-error-in-woocommerce-tax-taxjar-integration-conflict-with-square
Steps to reproduce & screenshots/GIFs
Checklist
changelog.txt
entry addedreadme.txt
entry added