Skip to content

Circleci project setup #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

AllTerrainDeveloper
Copy link
Contributor

@AllTerrainDeveloper AllTerrainDeveloper commented Jun 23, 2022

Add .circleci/config.yml in order to run the tests in the CI server.

image

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I appreciate how sparse the config is. Confirmed that the tests ran by looking at the Checks output, but I didn't confirm that failed tests prevent merge - I'm not too worried about that though.

Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking, why are we referencing yarn in this?

# https://circleci.com/developer/images/image/cimg/node
version: '16.10'
# If you are using yarn, change the line below from "npm" to "yarn"
pkg-manager: yarn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this npm here no? that's the way the docs indicate this should be built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants