-
Notifications
You must be signed in to change notification settings - Fork 21
Add/refresh data #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AllTerrainDeveloper
wants to merge
15
commits into
master
Choose a base branch
from
add/refresh-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add/refresh data #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See raw JSON response - Copy to clipboard shortcut
@@ -36,7 +36,7 @@ const ParamBuilder = ( { title, params, values = {}, onChange } ) => { | |||
parameter={ parameter } | |||
id={ `param-${ paramKey }` } | |||
name={ paramKey } | |||
position="right" | |||
position={ 'bottom' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tooltip was invisible in the right side of the screen
<span className="duration">{ `${ duration }ms` }</span> | ||
<div> | ||
<span className="duration">{`${ duration }ms`}</span> | ||
<Refresh id={ id } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small icon to trigger the refresh of the row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore the oldest commits, I've messed up the rebase and ended up doing a merge into this branch 😂
Changes proposed in this Pull Request
UPDATE:

I've improved the loading state, now the refreshing row is shown up as loading until it receives data:
Test plan
Test 1
Test 2