Skip to content

Add/refresh data #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add/refresh data #96

wants to merge 15 commits into from

Conversation

AllTerrainDeveloper
Copy link
Contributor

@AllTerrainDeveloper AllTerrainDeveloper commented Apr 9, 2022

Please ignore the oldest commits, I've messed up the rebase and ended up doing a merge into this branch 😂

Changes proposed in this Pull Request

  1. The parameter description when using the query builder was outside of the screen when trying the get information from the body parameters. See screenshot Before/After
BEFORE AFTER
image image
  1. Added a refresh button, useful when we want to retry an old request, with all the body parameters/url parameters we used.

developer console new feature

UPDATE:
I've improved the loading state, now the refreshing row is shown up as loading until it receives data:
update wordpress developer console loading

Test plan

Test 1

  1. Checkout this branch and build it locally
  2. Click on the search input field and wait to see the full list of parameters (as per in the first two images in this PR)
  3. Look for a POST method with body parameters
  4. Hover over the parameters
  5. Assert that the tooltip is always visible

Test 2

  1. Checkout this branch and build it locally
  2. Do a few valid and different requests.
  3. Click on the refresh icons.
  4. Assert that the response time is updated.
  5. EXTRA: if you are running an instance of WordPress locally, modify the code to make it fail (As per in the first gif)
  6. Click on the refresh icons.
  7. Assert that the call fails.

@AllTerrainDeveloper AllTerrainDeveloper self-assigned this Apr 9, 2022
@@ -36,7 +36,7 @@ const ParamBuilder = ( { title, params, values = {}, onChange } ) => {
parameter={ parameter }
id={ `param-${ paramKey }` }
name={ paramKey }
position="right"
position={ 'bottom' }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooltip was invisible in the right side of the screen

<span className="duration">{ `${ duration }ms` }</span>
<div>
<span className="duration">{`${ duration }ms`}</span>
<Refresh id={ id } />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small icon to trigger the refresh of the row

@AllTerrainDeveloper AllTerrainDeveloper marked this pull request as ready for review April 9, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant