-
Notifications
You must be signed in to change notification settings - Fork 280
Update how-to-bind-tabs.md #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How is it misleading? It is a view model? It's not a template. The template is defined in the view using the |
Looks like you are right. In my understanding TabItemViewModel should always have TabItemView.axaml and is created only in such a bundle. This confuses me. |
Generally, yes. But there is no requirement for that. The view model can be used with any view that knows how to handle it. There is nothing stopping you from instead hooking the tab item up to something like a |
|
I still think there are good parts in this PR that I want to merge. What if we rename What do you think, @Reidea ? |
Good idea. I renamed it.. |
timunie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution and patiance. Very much appreciate it.
Fixed missing
ItemsSourcebinding. The binding should be a property that accesses the items collection. Renamed it toItems.The class name
TabViewModelis misleading. Renamed toTabItemTemplate.