feat: add example validation CI script (Closes #94) - #180
Open
panditdhamdhere wants to merge 5 commits into
Open
feat: add example validation CI script (Closes #94)#180panditdhamdhere wants to merge 5 commits into
panditdhamdhere wants to merge 5 commits into
Conversation
…oses Axionvera#94) Hardens pnpm check:examples with clear Zod error output, adds script unit tests, wires a GitHub Actions workflow, and documents when contributors should run validation.
Contributor
| \nGitHub has not finished calculating whether this PR can be merged cleanly.\n\nThe auto-merge automation will skip this PR for now. Re-run the automation later. |
Contributor
| \nThis PR is currently blocked by merge conflicts.\n\nPlease update the branch with the latest main branch and resolve the conflicts before it can be merged. |
Contributor
Author
|
kindly check now. |
The workflow pinned pnpm 9 while package.json declares pnpm@9.0.0, which made pnpm/action-setup fail with ERR_PNPM_BAD_PM_VERSION before install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check-examples.mtswith clear Zod path/message error output (--verbose)pnpm test:examplescovering valid and invalid example fixtures.github/workflows/check-examples.ymldocs/examples.mdand link from READMECloses #94
Issue scope
Affected packages / apps
apps/webpackages/typespackages/configpackages/fixturespackages/validatorspackages/stellar-kitpackages/anchor-utilscontracts/treasury-escrowdocs/scripts/check-examples.mts,scripts/check-examples.test.ts,.github/workflows/check-examples.yml,package.json,examples/,README.md,apps/web/app/docs/page.tsxTesting performed
pnpm check:examples -- --verbosepnpm test:examplesScreenshots / recordings
N/A
Security impact
Documentation impact
/docsupdated for this change