Non sensitive#282
Merged
Merged
Conversation
Contributor
|
This PR cannot be merged automatically because it has merge conflicts. Please update the branch with the latest base branch and resolve the conflicts. After the conflicts are resolved and checks pass, the automation can review it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Close #267
Summary of the issue:
Debugging tester issues is currently difficult without safe diagnostic information. The app needs a diagnostics screen that shows non-sensitive app, network, and wallet status (like initialization, balance load status, transaction counts) while completely redacting sensitive wallet secrets.
Root cause:
The application lacked a dedicated UI and routing to surface the application state securely. Testers and developers didn't have an easy way to view and export debugging metadata without risking the exposure of sensitive user keys or contact details.
Solution implemented:
Added a new
DiagnosticsScreencomponent and updated the development section inSettingsScreento navigate to it. The screen leverages the existingsrc/utils/diagnostics.tsutility to safely aggregate and redact diagnostic state (environment, app state, wallet state) and display it securely to the user. A clipboard copy function is provided for convenience.Key changes made:
app/diagnostics.tsx: Created a new screen that fetches non-sensitive state fromgetDiagnostics()and displays it in a scrollable, copyable format.app/(tabs)/settings.tsx: Replaced the stubbedhandleExportDiagnosticsmethod with navigation to the new diagnostics screen (/diagnostics). Additionally, fixed a preexisting unclosed<View>tag and variable reference (COLORS->colors) that was causing syntax errors on the screen.docs/diagnostics.md: Updated documentation to reflect the new dedicated screen approach rather than the native share dialog.Any trade-offs or considerations:
expo-clipboardto allow quick copying. This approach provides transparency, letting the user verify exactly what data is being shared.__DEV__flag to ensure this diagnostic tool is not exposed to production users.Testing steps (how to verify the fix):
npm start-> iOS/Android simulator).publicKey,secretKey, etc.) is omitted or transformed into boolean flags (hasPublicKey: true).Please kindly review this task. If there are any corrections, improvements, adjustments, or merge conflicts that you notice regarding my implementation, I'd really appreciate your feedback. I'd also love to hear your overall review of my work on this branch.Thank you!