Lockdeteails#284
Merged
Merged
Conversation
Contributor
|
This PR cannot be merged automatically because it has merge conflicts. Please update the branch with the latest base branch and resolve the conflicts. After the conflicts are resolved and checks pass, the automation can review it again. |
Contributor
Author
|
Thank you very much 😊
Cheers 🎉
…On Thu, Jul 23, 2026, 2:11 PM Muhammad Zayyad Mukhtar < ***@***.***> wrote:
*El-swaggerito* left a comment (Axionvera/pocketpay-mobile#284)
<#284 (comment)>
This PR cannot be merged automatically because it has merge conflicts.
Please update the branch with the latest base branch and resolve the
conflicts.
After the conflicts are resolved and checks pass, the automation can
review it again.
—
Reply to this email directly, view it on GitHub
<#284?email_source=notifications&email_token=BMBZJ5FK2TH3WSWFUCMI62D5GIFHPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBVHA3TONRYGMZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5058776832>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMBZJ5CUIKU3A2IRDPGPLTL5GIFHPAVCNFSNUABGKJSXA33TNF2G64TZHMYTGMBSGMZDQNZRG45US43TOVSTWNBZGU4TCMZZG44TNILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BMBZJ5FQFRTLIJIIQ5S3MP35GIFHPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBVHA3TONRYGMZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BMBZJ5BFQRORIFN3WZSWPQL5GIFHPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBVHA3TONRYGMZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Close #263
Summary of the issue:
Users need the ability to inspect individual vault locks before executing a withdrawal to check the amount, created/unlock dates, status, and eligibility.
Root cause:
The application lacked a dedicated screen to display the metadata for a single vault lock. Without this, users couldn't easily verify if a lock had matured without attempting a withdrawal.
Solution implemented:
Added a
VaultLockDetailScreenthat displays key lock metadata (amount, created date, unlock date, status) and visually indicates whether the lock is eligible for withdrawal based on the current date. A "Mock Active Locks" list was also added to the main Vault tab, allowing users to navigate to the new detail screen while the full SDK integration is pending.Key changes made:
app/vault-lock/[id].tsx: Created the new detail screen usingexpo-routerdynamic routing to parse the lock ID. Renders mock data with clear typography and icons fromlucide-react-native. Calculates withdrawal eligibility by comparing the unlock date to the current date and conditionally renders status badges and button states.app/(tabs)/vault.tsx: ImporteduseRouterand appended a "Mock Active Locks" section below the existing action buttons to provide an entry point for testing the new screen.Any trade-offs or considerations:
Testing steps (how to verify the fix):
Please kindly review this task. If there are any corrections, improvements, adjustments, or merge conflicts that you notice regarding my implementation, I'd really appreciate your feedback. I'd also love to hear your overall review of my work on this branch.Thank you!