feat: implement mobile transaction cancellation handling and related … - #287
Merged
El-swaggerito merged 1 commit intoJul 23, 2026
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199
✅ Cancellation handling has been wired up cleanly
I updated the payment/signing flow so an intentional cancel is kept separate from a real failure:
cancelSigning()now moves the state tocancelledand safely clearscurrentReview,lastResult, anderror.Result
This satisfies the key behavior requested:
Verification
I reproduced the regression first with the targeted Jest test:
npm test -- --runInBand __tests__/signerStore.cancelled.test.tserrorpopulated.I then validated the edited files with static diagnostics, and signerStore.ts, useSignerHandoff.ts, and review-transaction.tsx report no file-level errors.
Made changes.