forked from AtomicBot-ai/Atomic-Chat
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: use-mobile hook crashes on older Safari without MediaQueryList.addEventListener #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| import { describe, it, expect, vi, afterEach } from 'vitest' | ||
| import { renderHook } from '@testing-library/react' | ||
| import { useIsMobile } from '../use-mobile' | ||
|
|
||
| afterEach(() => { | ||
| vi.restoreAllMocks() | ||
| vi.useRealTimers() | ||
| }) | ||
|
|
||
| describe('useIsMobile', () => { | ||
| it('returns false on a wide screen', () => { | ||
| Object.defineProperty(window, 'innerWidth', { value: 1024, writable: true }) | ||
| const mql = { | ||
| addEventListener: vi.fn(), | ||
| removeEventListener: vi.fn(), | ||
| } | ||
| vi.spyOn(window, 'matchMedia').mockReturnValue(mql as any) | ||
|
|
||
| const { result } = renderHook(() => useIsMobile()) | ||
| expect(result.current).toBe(false) | ||
| }) | ||
|
|
||
| it('returns true on a narrow screen', () => { | ||
| Object.defineProperty(window, 'innerWidth', { value: 400, writable: true }) | ||
| const mql = { | ||
| addEventListener: vi.fn(), | ||
| removeEventListener: vi.fn(), | ||
| } | ||
| vi.spyOn(window, 'matchMedia').mockReturnValue(mql as any) | ||
|
|
||
| const { result } = renderHook(() => useIsMobile()) | ||
| expect(result.current).toBe(true) | ||
| }) | ||
|
|
||
| it('falls back to deprecated addListener on older browsers that lack addEventListener on MediaQueryList', () => { | ||
| const consoleWarnSpy = vi | ||
| .spyOn(console, 'warn') | ||
| .mockImplementation(() => {}) | ||
|
|
||
| const mql = { | ||
| addEventListener: vi.fn(() => { | ||
| throw new Error('addEventListener not supported on MediaQueryList') | ||
| }), | ||
| removeEventListener: vi.fn(), | ||
| addListener: vi.fn(), | ||
| removeListener: vi.fn(), | ||
| } | ||
| vi.spyOn(window, 'matchMedia').mockReturnValue(mql as any) | ||
| Object.defineProperty(window, 'innerWidth', { value: 1024, writable: true }) | ||
|
|
||
| renderHook(() => useIsMobile()) | ||
|
|
||
| expect(mql.addListener).toHaveBeenCalledWith(expect.any(Function)) | ||
| consoleWarnSpy.mockRestore() | ||
| }) | ||
|
|
||
| it('removes the deprecated listener on unmount in older browsers', () => { | ||
| vi.spyOn(console, 'warn').mockImplementation(() => {}) | ||
|
|
||
| const mql = { | ||
| addEventListener: vi.fn(() => { | ||
| throw new Error('addEventListener not supported') | ||
| }), | ||
| removeEventListener: vi.fn(), | ||
| addListener: vi.fn(), | ||
| removeListener: vi.fn(), | ||
| } | ||
| vi.spyOn(window, 'matchMedia').mockReturnValue(mql as any) | ||
| Object.defineProperty(window, 'innerWidth', { value: 1024, writable: true }) | ||
|
|
||
| const { unmount } = renderHook(() => useIsMobile()) | ||
| unmount() | ||
|
|
||
| expect(mql.removeListener).toHaveBeenCalledWith(expect.any(Function)) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Test the absent
addEventListenercondition.Lines 40-46 and Lines 60-66 define
addEventListenerand force it to throw. Older Safari lacks this method. RemoveaddEventListenerandremoveEventListenerfrom both fixtures so the tests verify the actual compatibility path.Proposed test fixture change
const mql = { - addEventListener: vi.fn(() => { - throw new Error('addEventListener not supported on MediaQueryList') - }), - removeEventListener: vi.fn(), addListener: vi.fn(), removeListener: vi.fn(), }Also applies to: 60-66
🤖 Prompt for AI Agents