Fix LargePayload sample build: rename ExternalizeThresholdBytes to ThresholdBytes#308
Merged
Merged
Conversation
The Microsoft.DurableTask.Extensions.AzureBlobPayloads package renamed
LargePayloadStorageOptions.ExternalizeThresholdBytes to ThresholdBytes
in version 1.23.3. The sample was pinned to 1.21.0 (which exposed the
old name), but CI is resolving a newer version, causing 'Build DTS -
LargePayload' to fail with CS1061 on main and on every open PR.
- Bump Microsoft.DurableTask.{Client,Worker}.AzureManaged and
Microsoft.DurableTask.Extensions.AzureBlobPayloads from 1.21.0 to
1.24.2 (latest stable) so the package versions match the API the
source code uses.
- Bump Azure.Identity from 1.18.0 to 1.21.0 to satisfy the new
transitive constraint from Microsoft.DurableTask.Client.AzureManaged
1.24.2 (otherwise NU1605 fires).
- Rename the single SDK option assignment from ExternalizeThresholdBytes
to ThresholdBytes to match the new API surface.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
torosent
force-pushed
the
fix/largepayload-threshold-bytes-api
branch
from
4aa1af0 to
97e5157
Compare
torosent
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a CI build failure in the LargePayload .NET sample by updating the SDK option name to match the renamed API in Microsoft.DurableTask.Extensions.AzureBlobPayloads v1.23.3+ (ExternalizeThresholdBytes → ThresholdBytes), and bumping package versions accordingly.
Changes:
- Rename
options.ExternalizeThresholdBytestooptions.ThresholdBytesinProgram.cs. - (Per PR description) Bump
Microsoft.DurableTask.*packages to 1.24.2 andAzure.Identityto 1.21.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Build DTS - LargePayloadis currently failing onmainand on every open PR (e.g. PR #307 run) with:In
Microsoft.DurableTask.Extensions.AzureBlobPayloads,LargePayloadStorageOptions.ExternalizeThresholdByteswas renamed toThresholdBytesstarting in v1.23.3.Dependabot's nuget-all group bump (PR #287) raised the sample's reference from 1.21.0 → 1.24.1 on main, but did not update the source to use the new property name. This PR fills that gap.
What
samples/durable-task-sdks/dotnet/LargePayload/Program.cs: rename the single SDK option assignment fromExternalizeThresholdBytestoThresholdBytes.No
.csprojchange — package versions on main already expose the new API.Verification
Once this lands on
main, the existing Dependabot PRs (including #307) will be unblocked on the next CI run.