Skip to content

JWT, use expiry from token #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rido-min wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JWT, use expiry from token #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions mqttclients/dotnet/MQTTnet.Client.Extensions/WithJWT.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,21 @@ namespace MQTTnet.Client.Extensions
{
public static partial class MqttNetExtensions
{
static Func<byte[]> _getTokenCallBack = null!;
static Func<(byte[], TimeSpan)> _getTokenCallBack = null!;
static Timer _refreshTimer = null!;


public static MqttClientOptionsBuilder WithJWT(this MqttClientOptionsBuilder builder, MqttConnectionSettings cs, Func<byte[]> getTokenCallBack, IMqttClient mqttClient, TimeSpan refreshPeriod)
public static MqttClientOptionsBuilder WithJWT(this MqttClientOptionsBuilder builder, MqttConnectionSettings cs, Func<(byte[], TimeSpan)> getTokenCallBack, IMqttClient mqttClient)
{
_getTokenCallBack = getTokenCallBack;

(byte[] token, TimeSpan ts) = getTokenCallBack();
Trace.TraceInformation($"Token expires in {ts.TotalSeconds} seconds");
builder
.WithConnectionSettings(cs)
.WithAuthentication("OAUTH2-JWT", getTokenCallBack());
.WithAuthentication("OAUTH2-JWT", token);

_refreshTimer = new Timer(RefreshToken, mqttClient, 0, Convert.ToInt32(refreshPeriod.TotalMilliseconds));
_refreshTimer = new Timer(RefreshToken, mqttClient, 0, (int)ts.TotalSeconds * 1000);
return builder;
}

Expand All @@ -30,7 +32,7 @@ static void RefreshToken(object? state)
await mqttClient.SendExtendedAuthenticationExchangeDataAsync(
new MqttExtendedAuthenticationExchangeData()
{
AuthenticationData = _getTokenCallBack(),
AuthenticationData = _getTokenCallBack().Item1,
ReasonCode = MQTTnet.Protocol.MqttAuthenticateReasonCode.ReAuthenticate
});
});
Expand Down
6 changes: 3 additions & 3 deletions scenarios/jwt_authentication/dotnet/jwt_authentication/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

IMqttClient mqttClient = new MqttFactory().CreateMqttClient(MqttNetTraceLogger.CreateTraceLogger());
MqttClientConnectResult connAck = await mqttClient!.ConnectAsync(new MqttClientOptionsBuilder()
.WithJWT(cs, GetToken, mqttClient, TimeSpan.FromHours(1))
.WithJWT(cs, GetToken, mqttClient)
.Build());

Console.WriteLine($"Client Connected: {mqttClient.IsConnected} with CONNACK: {connAck.ResultCode} with auth method {mqttClient.Options.AuthenticationMethod}");
Expand All @@ -33,10 +33,10 @@
await Task.Delay(10000);
}

static byte[] GetToken()
static (byte[], TimeSpan) GetToken()
{
DefaultAzureCredential defaultCredential = new();
Console.WriteLine($"---- Get Token {DateTime.Now.ToString("o")} ----");
AccessToken jwt = defaultCredential.GetToken(new TokenRequestContext(new string[] { "https://eventgrid.azure.net/.default" }));
return Encoding.UTF8.GetBytes(jwt.Token);
return (Encoding.UTF8.GetBytes(jwt.Token), jwt.ExpiresOn.Subtract(DateTime.UtcNow));
}