feat(ui): migrate truth feature module#1146
Merged
Merged
Conversation
UI route-segment bundle budgetsAdvisory at v1 (does not block PRs). Strict mode activates after the F1 cleanup follow-up trims dead-weight deps from the global path. Budgets live in |
84a4961 to
86c5692
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/ui/src/features/truth/with a public feature facade.@/src/features/truth.apps/ui/README.md.Governance notes
Azure-Samples/holiday-peak-hubviaorigin.--no-verifyafter the focused UI validation below passed.Validation
cd apps/ui; yarn lint --max-warnings 0passed.cd apps/ui; yarn test --runInBand --runTestsByPath tests/unit/useEnrichmentMonitor.test.tsx tests/unit/enrichmentComponents.test.tsx tests/unit/pagesRender.test.tsxpassed: 3 suites, 32 tests.cd apps/ui; yarn test --runInBandpassed: 77 suites, 462 tests.git diff --check origin/main..HEADpassed.Known unrelated validation note
cd apps/ui; yarn type-checkcurrently fails becausetests/unit/featureIsolationLint.test.tsimportseslintwithout TypeScript declarations (@types/eslint). That test was introduced by feat(ui): add ESLint no-restricted-imports rule for feature isolation #991 and is unrelated to this truth feature migration.