feat(ui): migrate search feature module#1147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/ui/src/features/search/with a public@/src/features/searchfacade.ConfidenceBadge, intent/product-use-case helpers) intoapps/ui/src/shared/components/so truth/search consumers do not deep-import across feature boundaries.@types/eslintso the feat(ui): add ESLint no-restricted-imports rule for feature isolation #991 feature-isolation lint contract test passesui-qualitytype-check.searchin the migrated feature list inapps/ui/README.md.Governance notes
Azure-Samples/holiday-peak-hubviaorigin.--no-verifybecause it runs broad unrelated Python lint/test gates; focused UI validation below passed.Validation
cd apps/ui; yarn type-checkpassed.cd apps/ui; yarn lint --max-warnings 0passed.cd apps/ui; yarn test --runInBand --runTestsByPath tests/unit/SearchPage.test.tsx tests/unit/useIntelligentSearch.test.tsx tests/unit/AppSearchBox.test.tsx tests/unit/appSearchMatcher.test.ts tests/unit/appSearchUrlSeed.test.tsx tests/unit/semanticSearchService.test.ts tests/unit/ChatWidget.test.tsx tests/unit/enrichmentComponents.test.tsx tests/unit/pagesRender.test.tsxpassed: 9 suites, 75 tests.git grep -n --untracked -E "@/src/features/search/(components|hooks|services|types|internal)/" -- apps/uireturned no matches.git diff --check origin/main..HEADpassed.