fix: Expand tilde for chdir (issue #389) #390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredfholgate
requested changes
Jul 9, 2025
| @@ -23,6 +23,11 @@ function Invoke-Terraform { | |||
| [switch] $silent | |||
| ) | |||
|
|
|||
| # Avoid bootstrap Terraform chdir errors if ~ in moduleFolderPath | |||
| if ($env:HOME -and $env:HOME -ne "" -and $moduleFolderPath -match '^(~)') { | |||
There was a problem hiding this comment.
Can we make this work for Windows too?
E.g.
$homeDirectoryPath = $env:HOME
if($IsWindows) {
$homeDirectoryPath = $env:HOMEPATH
}
...There was a problem hiding this comment.
Actually, you can just use $HOME for a cross platform solution in PowerShell Core.
There was a problem hiding this comment.
Even better, just use Resolve-Path $moduleFolderPath.
There was a problem hiding this comment.
So change to (Resolve-Path ~/accelerator/output).Path?
This gives a consistent result (that should work for chdir) for
- absolute path
- relative path
- path including tilde
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback 👂
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback 👂
richeney
commented
Jul 9, 2025
richeney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #389
Description
Expands ~ with $env:HOME if found in moduleFolderPath
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.