Add support for CancellationToken during refresh operations - #281
Merged
Conversation
Avani Gupta (avanigupta)
requested review from
Jimmy Campbell (jimmyca15) and
Zhenlan Wang (zhenlan)
October 18, 2021 22:40
Avani Gupta (avanigupta)
force-pushed
the
avanigupta/cancellationtoken
branch
from
October 19, 2021 20:09
61322dc to
0c742aa
Compare
Jimmy Campbell (jimmyca15)
approved these changes
Oct 19, 2021
Jimmy Campbell (jimmyca15)
requested changes
Oct 19, 2021
Jimmy Campbell (jimmyca15)
approved these changes
Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a cancellation token to
RefreshAsyncandTryRefreshAsyncmethods.Since the
IConfigurationRefresherinterface has changed, this is a breaking change. However, users will still be able to callRefreshAsync()andTryRefreshAsync()without any parameter.Fix #275