Initial vendoring mock-up #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgklein
commented
Apr 4, 2019
bgklein
commented
Apr 4, 2019
| @@ -73,22 +79,39 @@ def jobparameter_from_json(json_data): | |||
| :param dict json_data: The JSON specification of an AddJobParameter or an | |||
| ExtendedJobParameter or a JobTemplate | |||
| """ | |||
| # json_data = templates.convert_blob_source_to_http_url(json_data) | |||
There was a problem hiding this comment.
Need to uncomment this before merge, but was required for POC that this would have worked with last API
bgklein
force-pushed
the
vendor-versioning
branch
17 times, most recently
from
1fd9d63 to
5df0fb9
Compare
bgklein
force-pushed
the
vendor-versioning
branch
3 times, most recently
from
ee8ccd5 to
36d02c4
Compare
1 similar comment
bgklein
force-pushed
the
vendor-versioning
branch
2 times, most recently
from
6629782 to
afb6609
Compare
bgklein
force-pushed
the
vendor-versioning
branch
from
61ab985 to
be1b5ef
Compare
xingwu1
previously approved these changes
Apr 16, 2020
| return convert_blobs_to_resource_files(blobs, resource_file) | ||
| if resource_file.source.url: | ||
| # TODO: Input data from an arbitrary HTTP GET source | ||
| raise ValueError('Not implemented') |
There was a problem hiding this comment.
Maybe change to "Not supported with source.url"?
| raise ValueError('Not implemented') | ||
| raise ValueError('Malformed ResourceFile') | ||
| if hasattr(resource_file, 'source') and resource_file.source: | ||
| if resource_file.source.file_group: |
There was a problem hiding this comment.
For latest cli, can we just call native batch feature instead of client work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge.
Currently has a mock-up as if we implemented it for the last REST API for POC, but we will likely want to start with the current API.