enable dual NIC support in transparent VLAN #4057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables dual NIC support in transparent VLAN by adding the ability to skip default routes and improving ARP proxy configuration for transparent VLAN clients. This enhancement allows for better network isolation and custom routing scenarios in multi-interface container environments.
- Added SkipDefaultRoutes field to network container request/response contracts
- Implemented ARP proxy setting and custom subnet route addition for VLAN interfaces
- Enabled dual NIC feature support on Linux platform
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| network/transparent_vlan_endpointclient_linux.go | Added ARP proxy configuration and custom routing logic with SkipDefaultRoutes support |
| cns/restserver/util.go | Propagated SkipDefaultRoutes field in network container responses and IP configuration |
| cns/NetworkContainerContract.go | Added SkipDefaultRoutes field to request/response contracts and updated string representation |
| cni/network/network_linux.go | Enabled dual NIC feature support for Linux platform |
| cni/network/multitenancy.go | Added SkipDefaultRoutes field to interface info configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mugeshsp
requested review from
QxBytes and
tamilmani1989
and removed request for
QxBytes
|
@mugeshsp please fix lint errors |
mugeshsp
force-pushed
the
mugeshsp/pg-dual-nic
branch
from
850cadc to
6fde3f8
Compare
|
@microsoft-github-policy-service agree company="Microsoft" |
Fixed the lint errors |
tamilmani1989
previously approved these changes
Oct 7, 2025
paulyufan2
previously approved these changes
Oct 9, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
reviewed
Oct 9, 2025
mugeshsp
dismissed stale reviews from paulyufan2 and tamilmani1989
via
304db52
QxBytes
approved these changes
Oct 15, 2025
paulyufan2
approved these changes
Oct 22, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* feat: add SkipDefaultRoutes field to network container request and responses * feat: implement ARP proxy setting and custom route addition for VLAN interfaces * feat: enable dual NIC feature support and improve ARP proxy handling in transparent VLAN client * feat: add tests for SkipDefaultRoutes handling in network container requests * feat: remove addition of custom routes * fix: improve ARP proxy error handling * fix: Lint Errors * refactor: streamline ARP proxy setup in AddEndpointRules * fix: update comments for dual NIC support and clarify ARP proxy function --------- Co-authored-by: Mugesh SP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Enables dual NIC feature support in Azure Container Networking by adding the ability to skip default routes and improving ARP proxy configuration for transparent VLAN clients. This enhancement allows for better network isolation and custom routing scenarios in multi-interface container environments.
Requirements:
Notes:
This PR includes three main commits: