fix: Adding delete timestamp check #4078
Merged
+77
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
previously requested changes
Oct 15, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to prevent IP configuration requests for pods with terminating MultitenantPodNetworkConfig (MTPNC) resources by checking if the deletion timestamp is set.
- Introduces an
IsTerminating()method to check if a MTPNC resource has a deletion timestamp - Adds validation in the middleware to reject requests when MTPNC is terminating
- Includes test coverage for the terminating state scenario
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crd/multitenancy/api/v1alpha1/utils.go | Adds IsTerminating() method to check deletion timestamp |
| cns/middlewares/k8sSwiftV2.go | Implements validation to reject IP config requests when MTPNC is terminating |
| cns/middlewares/mock/mockClient.go | Adds mock data for testing MTPNC terminating state |
| cns/middlewares/k8sSwiftV2_linux_test.go | Adds test case to verify terminating state is properly handled |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shreyashastantram
changed the title
Co-authored-by: Copilot <[email protected]> Signed-off-by: shreyashastantram <[email protected]>
miguelgoms
reviewed
Oct 16, 2025
isaac-dasan
requested changes
Oct 16, 2025
isaac-dasan
requested changes
Oct 20, 2025
miguelgoms
previously approved these changes
Oct 20, 2025
isaac-dasan
previously approved these changes
Oct 21, 2025
ashvindeodhar
previously approved these changes
Oct 21, 2025
miguelgoms
previously approved these changes
Oct 21, 2025
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
reviewed
Oct 21, 2025
shreyashastantram
dismissed stale reviews from miguelgoms, ashvindeodhar, and isaac-dasan
via
f0f45aa
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
miguelgoms
approved these changes
Oct 21, 2025
isaac-dasan
approved these changes
Oct 21, 2025
ashvindeodhar
approved these changes
Oct 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* Adding delete timestamp check * Adding UT and refactoring getmtpnc * Update cns/middlewares/k8sSwiftV2_linux_test.go Co-authored-by: Copilot <[email protected]> Signed-off-by: shreyashastantram <[email protected]> * Changing the MTPNC error message * Removing unused fields * Revert manifest changes for CRD files * Fixing error message and adding comments * Revert CRD API files to master state * fix: correcting comment assertion --------- Signed-off-by: shreyashastantram <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding check to MTPNC to ensure that CNS doesn't respond back with the ipaddress if mtpnc is set for deletion.
Issue Fixed:
Requirements:
Notes: