-
Notifications
You must be signed in to change notification settings - Fork 257
[Azure CNS] Bug Fix for Overlay Subnet Expansion #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in Azure CNS where overlay subnet expansions were incorrectly triggering PrimaryCA mismatch errors. The fix adds scenario-aware validation that skips the subnet comparison check for overlay network containers when subnet expansion occurs.
Key Changes:
- Added
Scenario
field toCreateNetworkContainerRequest
to track the network container type - Modified validation logic to skip PrimaryCA comparison for overlay scenarios
- Populated the
Scenario
field in both dynamic and static NC request creation paths
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
cns/NetworkContainerContract.go | Adds Scenario field to track NC type |
cns/restserver/internalapi.go | Implements conditional PrimaryCA validation based on scenario |
cns/kubecontroller/nodenetworkconfig/conversion.go | Sets Scenario field for dynamic NC requests |
cns/kubecontroller/nodenetworkconfig/conversion_linux.go | Sets Scenario field for static NC requests |
cns/restserver/util.go | Removes unnecessary blank line |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
893e491
to
c853b69
Compare
Reason for Change:
Issue Fixed:
Requirements:
Notes: