Skip to content

Conversation

shreyashastantram
Copy link
Contributor

Reason for Change:

Issue Fixed:

Requirements:

Notes:

@Copilot Copilot AI review requested due to automatic review settings October 17, 2025 18:02
@shreyashastantram shreyashastantram requested a review from a team as a code owner October 17, 2025 18:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Expands MultitenantPodNetworkConfig visibility and lifecycle status tracking.

  • Adds PodUID and Status printer columns; removes PodNetwork printer column.
  • Introduces new MTPNCStatusDeleting status constant.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crd/multitenancy/manifests/multitenancy.acn.azure.com_multitenantpodnetworkconfigs.yaml Adjusts CRD printer columns to include PodUID and Status, removes PodNetwork.
crd/multitenancy/api/v1alpha1/multitenantpodnetworkconfig.go Adds PodUID and Status printcolumn annotations and new Deleting status constant.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

MTPNCStatusPNINotReady MTPNCStatus = "PNINotReady"
MTPNCStatusNodeCapacityExceeded MTPNCStatus = "NodeCapacityExceeded"
MTPNCStatusIPsExhausted MTPNCStatus = "IPsExhausted"
MTPNCStatusDeleting MTPNCStatus = "Deleting"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The new status MTPNCStatusDeleting is introduced without accompanying documentation on when it is set or how controllers should transition from/to it. Please add a brief comment above the status constants explaining each status, especially Deleting (e.g., whether it indicates a finalizer in progress, resource cleanup, or a terminal state).

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant