fix: aliases field missing from RegisteredModel record#277
Merged
Conversation
…egisteredModel.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason Wang <jasonwang_83@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the previously missing aliases field on the RegisteredModel record in the Unity Catalog client and ensures tests account for it.
- Introduces
Aliases,BrowseOnly, andCommentproperties (with JSON mappings) toRegisteredModel - Updates the unit test to include the
aliasesarray in the sample JSON response - Cleans up an unused
usingdirective in the test file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/Microsoft.Azure.Databricks.Client/Models/UnityCatalog/RegisteredModel.cs | Added Aliases, BrowseOnly, and Comment fields with documentation and JSON mappings |
| csharp/Microsoft.Azure.Databricks.Client.Test/UnityCatalog/RegisteredModelsApiClientTests.cs | Updated test JSON to include aliases and removed unused System.Reflection import |
Comments suppressed due to low confidence (1)
csharp/Microsoft.Azure.Databricks.Client.Test/UnityCatalog/RegisteredModelsApiClientTests.cs:83
- Expand this JSON sample to include
"browse_only": true(orfalse) and"comment": "some text", and add corresponding assertions to verify theBrowseOnlyandCommentproperties are deserialized correctly.
""aliases"": [],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #272