provisioning: allow for provisioning stages #5492
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weikanglim
force-pushed
the
weilim/stages
branch
from
6168f58 to
2503dc8
Compare
This change allows for additional provisioning stages to be defined in azure.yaml as `infra.stages`. The following commands have been updated to reflect this change: - `provision [stage]` -- Provisioning now accepts a stage name - `env refresh` -- Refresh state from all stages by default - `env refresh --stage [stage]` -- Refresh from a stage - `down` -- Delete resources from all stages by default - `down --stage [stage]` -- Delete resources from a stage Note: Behavior of`pipeline config` is left unchanged; and will require separate treatment in a follow-up change.
weikanglim
force-pushed
the
weilim/stages
branch
from
2503dc8 to
06fa759
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
JeffreyCA
reviewed
Jul 18, 2025
| return &cobra.Command{ | ||
| Use: "provision", | ||
| cmd := &cobra.Command{ | ||
| Use: "provision [stage]", |
There was a problem hiding this comment.
What are your thoughts on having an --all flag to be able to provision all stages, similar to how azd deploy --all deploys all services?
There was a problem hiding this comment.
For this concept I believe stage is referring to things like dev, test, prod, etc. It would be weird for an azd provision command to provision resources for all of these stages in a given command.
JeffreyCA
reviewed
Jul 18, 2025
| @@ -598,7 +605,8 @@ func (p *BicepProvider) Deploy(ctx context.Context) (*provisioning.DeployResult, | |||
| } | |||
|
|
|||
| deploymentTags := map[string]*string{ | |||
| azure.TagKeyAzdEnvName: to.Ptr(p.env.Name()), | |||
| azure.TagKeyAzdEnvName: to.Ptr(p.env.Name()), | |||
| azure.TagKeyAzdStageName: &p.stage, | |||
There was a problem hiding this comment.
What value are we setting the azd-stage-name tag to for the "default" stage (the one provisioned by running azd provision)?
Just trying to understand how this works with the changes in cli/azd/pkg/infra/deployment_manager.go
wbreza
reviewed
Jul 22, 2025
| return &cobra.Command{ | ||
| Use: "provision", | ||
| cmd := &cobra.Command{ | ||
| Use: "provision [stage]", |
There was a problem hiding this comment.
For this concept I believe stage is referring to things like dev, test, prod, etc. It would be weird for an azd provision command to provision resources for all of these stages in a given command.
| global *internal.GlobalCommandOptions | ||
| internal.EnvFlag | ||
| } | ||
|
|
||
| func (er *envRefreshFlags) Bind(local *pflag.FlagSet, global *internal.GlobalCommandOptions) { | ||
| local.StringVarP(&er.hint, "hint", "", "", "Hint to help identify the environment to refresh") | ||
| local.StringVarP(&er.stage, "stage", "", "", "Stage to refresh the environment from.") |
There was a problem hiding this comment.
How is an environment associated with a stage? Is it just the usage of the --stage attribute during provision commands right now?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for additional provisioning stages to be defined in azure.yaml as
infra.stages.The following commands have been updated to reflect this change:
provision [stage]-- Provisioning now accepts a stage nameenv refresh-- Refresh state from all stages by defaultenv refresh --stage [stage]-- Refresh from a stagedown-- Delete resources from all stages by defaultdown --stage [stage]-- Delete resources from a stageNote: Behavior of
pipeline configis left unchanged; and will require separate treatment in a follow-up change.Example
Example azure.yaml that incorporates stages and workflows:
UX
env refresh
provision
down