Add Rewind to .NET isolated #3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2025 11:35
cgillum
approved these changes
Oct 30, 2025
added 12 commits
November 3, 2025 20:06
cgillum
approved these changes
Nov 7, 2025
Comment on lines
+110
to
+117
| if (this.fixture.functionLanguageLocalizer.GetLanguageType() == LanguageType.DotnetIsolated) | ||
| { | ||
| Assert.Equal(HttpStatusCode.PreconditionFailed, rewindResponse.StatusCode); | ||
| } | ||
| else | ||
| { | ||
| Assert.Equal(HttpStatusCode.BadRequest, rewindResponse.StatusCode); | ||
| } |
Member
There was a problem hiding this comment.
Why different response values depending on the language? Should we add comments explaining this?
Collaborator
Author
There was a problem hiding this comment.
I tried to explain this in the comment for the first instance of where this happens (maybe the placement of the comment is not great)
// For all of the following tests, since Node throws a generic error in the case of a failure to rewind there is no great way
// to return specific status codes, whereas .NET isolated returns specific error types which can be used to return specific status codes.
// So, in the Node case, we simply check for the BadRequest status code.
Collaborator
There was a problem hiding this comment.
This is generally true for gRPC vs HTTP worker SDKs, and is also true for APIs like suspend/resume/terminate, where we have similar logic in the E2E tests.
andystaples
reviewed
Nov 7, 2025
Comment on lines
+110
to
+117
| if (this.fixture.functionLanguageLocalizer.GetLanguageType() == LanguageType.DotnetIsolated) | ||
| { | ||
| Assert.Equal(HttpStatusCode.PreconditionFailed, rewindResponse.StatusCode); | ||
| } | ||
| else | ||
| { | ||
| Assert.Equal(HttpStatusCode.BadRequest, rewindResponse.StatusCode); | ||
| } |
Collaborator
There was a problem hiding this comment.
This is generally true for gRPC vs HTTP worker SDKs, and is also true for APIs like suspend/resume/terminate, where we have similar logic in the E2E tests.
added 2 commits
November 7, 2025 09:32
andystaples
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the rewind API for .NET isolated apps. It also adds logic to correctly handle the new ExecutionRewoundEvent in the protos.
Note: I plan to add E2E tests for this once a new version of the DTS emulator is released with the backend implementation for rewind. In the meantime I have added thorough integration tests to the DTS repo. The only functionality not tested is if the API correctly handles trying to rewind un-failed or non-existent orchestrations, which I have tested manually and this works as expected.
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.