-
Notifications
You must be signed in to change notification settings - Fork 464
Adopt central package management #11192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
79c84f1
to
296ec1f
Compare
296ec1f
to
294eecd
Compare
64d516f
to
c2656ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Azure Functions Host repository to use central package management via Directory.Packages.props files. The migration simplifies package version management by centralizing version definitions and leveraging MSBuild's central package management features.
Key Changes:
- Introduces central package management with Directory.Packages.props files at repository and project levels
- Removes explicit version numbers from individual project files, relying on centralized version definitions
- Standardizes StyleCop package usage across the solution while temporarily removing it from projects with warnings
- Updates MSBuild imports to use GetPathOfFileAbove for improved path resolution
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 3 comments.
Show a summary per file
:
File | Description |
---|---|
Directory.Packages.props | New root-level package version definitions with global StyleCop reference |
test/Directory.Packages.props | Test-specific package versions for testing frameworks and supporting libraries |
tools/ExtensionsMetadataGenerator/Directory.Packages.props | Tool-specific package versions with transitive pinning disabled |
Multiple .csproj files | Removed explicit Version attributes from PackageReference elements |
Multiple Directory.Build.* files | Updated MSBuild import paths using GetPathOfFileAbove |
Worker .props files | Changed Version to VersionOverride for worker package references |
test/WebJobs.Script.Abstractions/WebJobs.Script.Tests.Abstractions.csproj
Outdated
Show resolved
Hide resolved
<PackageReference Include="Microsoft.NET.Test.Sdk" PrivateAssets="all" /> | ||
<PackageReference Include="xunit" /> | ||
<PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space between attribute name and value. Should be <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" />
<PackageReference Include="Microsoft.NET.Test.Sdk" PrivateAssets="all" /> | |
<PackageReference Include="xunit" /> | |
<PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" /> | |
<PackageReference Include="Microsoft.NET.Test.Sdk" PrivateAssets="all" /> | |
<PackageReference Include="xunit" /> | |
<PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" /> |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally> | ||
</PropertyGroup> | ||
<!-- | ||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put these here as I am considering pinning these, but will evaluate after
Issue describing the changes in this PR
resolves #10619
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Migrates to central package management. Additional changes:
CentralPackageTransitivePinningEnabled=true