[Bug] Do not try to initialize the TableClient if the service is disabled

[liliankasem]

Issue describing the changes in this PR

resolves #11194

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

• Backporting to the in-proc branch is not required
  • Otherwise: Link to backporting PR
• My changes do not require documentation changes
  • Otherwise: Documentation issue linked to PR
• My changes should not be added to the release notes for the next release
  • Otherwise: I've added my notes to release_notes.md
• My changes do not need to be backported to a previous version
  • Otherwise: Backport tracked by issue/PR #issue_or_pr
• My changes do not require diagnostic events changes
  • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
• I have added all required tests (Unit tests, E2E tests)

Additional information

Do not try to initialize the TableClient if the service is disabled.

[mathewc]

It seems like an abuse to reference the field here, when the intent of the TableClient property is to ensure all usages go through the property.

Perhaps Dispose should just set _isEnabled to false, or call DisableService, which would cause FlushLogs to noop?

[liliankasem]

I did originally start with _isEnabled = false but we opted not to use that approach because of Fabio's comment: #11195 (comment)

This introduces a change in behavior and potential data loss if this was running properly (a client was already created) and logs were buffered.

The TableClient propery is overloaded and we have another issue to refactor the whole thing. This is patch in the meantime to address this bug #11194

[fabiocav]

Agreed, not an ideal pattern/fix, but I'm OK with us doing this if we're tracking a longer-term change.

[mathewc]

ok

[fabiocav]

Commented above. I'm OK with the change, but let's have a test in place to validate the behavior with the changes in place.

[liliankasem]

Discussed with Fabio and as we already have a solution for the core tools problem, we will close this PR in favour of a fixing the real issue with the TableClient property:

#11198