[WIP] Flow cancellation token to PendingItem #11196
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
commented
Jul 18, 2025
| IRpcWorkerChannel rpcWorkerChannel = null; | ||
| string workerId = Guid.NewGuid().ToString(); | ||
| _logger.LogDebug("Creating language worker channel for runtime:{runtime}", runtime); | ||
| _logger.LogWarning("Creating language worker channel for runtime:{runtime}", runtime); |
liliankasem
commented
Jul 18, 2025
| @@ -89,7 +92,7 @@ public async Task<FunctionMetadataResult> GetFunctionMetadataAsync(IEnumerable<R | |||
| if (IsJobHostStarting()) | |||
| { | |||
| _logger.LogDebug("JobHost is starting with state '{State}'. Initializing worker channel.", _scriptHostManager.State); | |||
| await _channelManager.InitializeChannelAsync(workerConfigs, _workerRuntime); | |||
| await _channelManager.InitializeChannelAsync(workerConfigs, _workerRuntime, _applicationLifetime.ApplicationStopping); | |||
There was a problem hiding this comment.
So my idea was to pass the _applicationLifetime.ApplicationStopping CT to StartWorkerProcessAsync -> PendingItem. (it doesn't have to come through WorkerFunctionMetadataProvider so let me know if you have better ideas)
The problem I am seeing with this is that when I cancel (exit the host) we don't see CT triggered until after the timeout period of PendingItem has run its course. We are blocking in a weird way and we need to get around that block for the CT to flow properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.mdAdditional information
Whilst investigating the core tools
ctrl+cissue I was able to narrow down the problem to this area of the code.Cancellation tokens are not passed through and so when we hit
Ctrl+Cand trigger the application stopping lifetime event, nothing happens because we are either waiting for a response from the worker (which never happens in this state since we kill the channel), or until timeout. The timeout is set to 1 minute and that's why it often takes a minute for the host to shut down (if the host is stopped during startup).