adding a read-only ContainerApps secret repository #11202
+316
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for Container Apps secrets by implementing a read-only secrets repository that reads secrets from mounted files in the container filesystem, transitioning from blob storage to Container Apps native secret management.
- Introduces
ContainerAppsSecretsRepositoryas a new read-only secrets repository implementation - Modifies
SecretManagerto handle nullable master keys for scenarios where secrets don't exist - Updates the secret manager provider to support the new "containerapps" secret storage type
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ContainerAppsSecretsRepository.cs | New read-only repository implementation that reads secrets from /run/secrets/functions-keys directory |
| DefaultSecretManagerProvider.cs | Adds support for "containerapps" secret storage type and instantiation of the new repository |
| SecretManager.cs | Updates to handle nullable master keys and removes unused import |
| ContainerAppsSecretsRepositoryTests.cs | Comprehensive test suite covering secret reading, empty scenarios, and SecretManager integration |
Comment on lines
141
to
+142
| // before caching any secrets, validate them | ||
| string masterKeyValue = hostSecrets.MasterKey.Value; | ||
| string masterKeyValue = hostSecrets.MasterKey?.Value; |
There was a problem hiding this comment.
The change to make masterKeyValue nullable without updating the ValidateHostSecrets method call could cause issues. The ValidateHostSecrets method may not be designed to handle null masterKeyValue parameter.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11166
Container Apps currently uses blob storage for it's secrets, which are not manageable easily. We're transitioning secrets to be managed via Container Apps itself. In this case, the secrets will be in a drive in the container the same way as our K8S secrets are.
The main difference here is that these are read-only. We have no mechanism for auto-generating these in Container Apps, so they need to be created separately.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md