Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Add API to add an IpSecurityRestriction while Defining a WebApp - #548

Open
Derek Petillo (dpetillo) wants to merge 4 commits into
Azure:masterfrom
dpetillo:app-service-add-ip-sec-restrictions
Open

Add API to add an IpSecurityRestriction while Defining a WebApp#548
Derek Petillo (dpetillo) wants to merge 4 commits into
Azure:masterfrom
dpetillo:app-service-add-ip-sec-restrictions

Conversation

@dpetillo

Copy link
Copy Markdown

I needed this functionality added to the API. If it can be added to master, I think ill need advisement on my API signature(s) and how to properly regenerate the model:

src\ResourceManagement\AppService\Generated\Models\IpSecurityRestriction.cs

The copy in this commit was taken from https://github.com/Azure/azure-sdk-for-net and lightly modified.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Dec 10, 2018

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@azuresdkci

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@hovsepm

Copy link
Copy Markdown
Contributor

Azure Builder (@azuresdkci) test this please.

@praries880 Pareekshit Singh (praries880) added App Services Mgmt Management plane SDK related issues. labels Apr 4, 2019
/// </summary>
/// <param name="ipAddress">IP address the security restriction is
/// valid for.</param>
/// valid for.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derek Petillo (@dpetillo)
you can undo these changes, The model got updated with these properties added to it :

public IpSecurityRestriction(string ipAddress = default(string), string subnetMask = default(string), string vnetSubnetResourceId = default(string), int? vnetTrafficTag = default(int?), int? subnetTrafficTag = default(int?), string action = default(string), IpFilterTag? tag = default(IpFilterTag?), int? priority = default(int?), string name = default(string), string description = default(string))

@praries880

Copy link
Copy Markdown
Contributor

Derek Petillo (@dpetillo)
Thanks for the PR :)

We have already updated the models to include the changes you have here. We still need to add a public API to make IPSecurityRestriction available on the Fluent API though. We will get try to get the suggestions here in webapps in the near future.

The API changes you made do look good, but we still have to look into the update (PATCH) scenario and add tests for the same.

@yaohaizh

Copy link
Copy Markdown

Tanyi Chen (@ChenTanyi) please follow with this PR. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

App Services Mgmt Management plane SDK related issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants