Skip to content

Refactor(impact): migrate to unified folder structure - #44603

Draft
v-jiaodi wants to merge 7 commits into
Azure:mainfrom
v-jiaodi:refactor-folder-impact
Draft

Refactor(impact): migrate to unified folder structure#44603
v-jiaodi wants to merge 7 commits into
Azure:mainfrom
v-jiaodi:refactor-folder-impact

Conversation

@v-jiaodi

Copy link
Copy Markdown
Member

This PR migrates the impact specification to the new unified folder structure according to Azure folder structure guidelines.

Change:

  • Consolidated TypeSpec and Swagger files under resource-manager\Microsoft.Impact\Impact
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Added suppressions.yaml for legacy API versions
  • Verified TypeSpec compilation works correctly
  • Updated the relevant paths in specification/suppressions.yaml file
  • Add rpaas readme.md under resource-manger

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

@v-jiaodi v-jiaodi added the FolderMigrationV2 A specific label for PRs like folder structure migration into v2. label Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMModelingAutoSignedOff package-name-review-required Package name review required before merge Mgmt This issue is related to a management-plane library. package-name-dotnet-pending .NET package name pending approval package-name-python-pending Python package name pending approval package-name-java-pending Java package name pending approval package-name-go-pending Go package name pending approval package-name-typescript-pending TypeScript package name pending approval labels Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Namespace Review Required

Plane: Management Plane

Language Proposed Namespace Format Status Approvers
dotnet Azure.ResourceManager.ImpactReporting ✅ Approved by @ArthurMa1978 @ArthurMa1978, @m-nash
python azure.mgmt.impactreporting ⚠️ Invalid ✅ Approved by @ArthurMa1978 @ArthurMa1978, @m-nash
java (package) com.azure.resourcemanager.impactreporting ✅ Approved by @ArthurMa1978 @ArthurMa1978, @m-nash
java (artifact) azure-resourcemanager-impactreporting ✅ Approved by @ArthurMa1978 @ArthurMa1978, @m-nash
go github.com/Azure/azure-sdk-for-go/{service-dir}/armimpactreporting ⚠️ Invalid ✅ Approved by @ArthurMa1978 @ArthurMa1978, @m-nash
typescript @azure/arm-impactreporting ✅ Approved by @ArthurMa1978 @ArthurMa1978, @m-nash

⚠️ Format issues detected:

  • python: "azure.mgmt.impactreporting" does not match expected format: azure-mgmt-{name} (lowercase)
  • go: "github.com/Azure/azure-sdk-for-go/{service-dir}/armimpactreporting" does not match expected format: sdk/resourcemanager/{name}/arm{name} (lowercase)

Format validation does not block approval but should be reviewed.

How to approve:

  • Per language: apply namespace-<language>-approved label
  • All at once: apply namespace-approved-all label (shortcut for mgmt plane)

Merge is blocked until all languages are approved.

Approver list: .github/namespace-approvers.yml
Process: .github/workflows/src/namespace-approval/NAMESPACE-REVIEW-PROCESS.md
Namespaces extracted from tspconfig.yaml emitter options

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Impact-Impact
TypeSpec Microsoft.Impact
Go sdk/resourcemanager/impactreporting/armimpactreporting
Python azure-mgmt-impactreporting
C# Azure.ResourceManager.ImpactReporting
Java com.azure.resourcemanager:azure-resourcemanager-impactreporting

Comment generated by After APIView workflow run.

@v-jiaodi

Copy link
Copy Markdown
Member Author

@v-jiaodi

Copy link
Copy Markdown
Member Author

@ArthurMa1978 ArthurMa1978 added the package-name-approved-all Shortcut: approve all languages at once (mgmt-plane) label Jul 24, 2026
@github-actions github-actions Bot added package-name-dotnet-approved .NET package name approved package-name-python-approved Python package name approved package-name-java-approved Java package name approved and removed package-name-dotnet-pending .NET package name pending approval package-name-python-pending Python package name pending approval labels Jul 24, 2026
@github-actions github-actions Bot added package-name-typescript-approved TypeScript package name approved package-name-go-approved Go package name approved and removed package-name-java-pending Java package name pending approval package-name-typescript-pending TypeScript package name pending approval package-name-go-pending Go package name pending approval package-name-review-required Package name review required before merge labels Jul 24, 2026
@github-actions

Copy link
Copy Markdown

✅ Namespace Approved

All required namespace approvals received. This PR is clear to merge from a namespace perspective.

@github-actions github-actions Bot added the package-name-approved All package name proposals approved label Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMModelingAutoSignedOff FolderMigrationV2 A specific label for PRs like folder structure migration into v2. Mgmt This issue is related to a management-plane library. package-name-approved All package name proposals approved package-name-approved-all Shortcut: approve all languages at once (mgmt-plane) package-name-dotnet-approved .NET package name approved package-name-go-approved Go package name approved package-name-java-approved Java package name approved package-name-python-approved Python package name approved package-name-typescript-approved TypeScript package name approved resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants