Skip to content

Fix csharp-mgmt emitter config for ContainerService NodeCustomization#44760

Draft
cxznmhdcxz wants to merge 1 commit into
Azure:mainfrom
cxznmhdcxz:nodecustomization-mpg
Draft

Fix csharp-mgmt emitter config for ContainerService NodeCustomization#44760
cxznmhdcxz wants to merge 1 commit into
Azure:mainfrom
cxznmhdcxz:nodecustomization-mpg

Conversation

@cxznmhdcxz

Copy link
Copy Markdown
Member

Summary

Fixes the C# management-plane emitter configuration for the ContainerService NodeCustomization TypeSpec project.

Problem

The @azure-typespec/http-client-csharp-mgmt emitter block declared a service-dir option. That emitter's option schema uses additionalProperties: false and does not define service-dir, so compilation failed with:

tspconfig.yaml - error invalid-schema: must NOT have additional properties (additionalProperty: service-dir)

This silently produced an empty src/ during .NET SDK generation.

Fix

Remove the invalid service-dir option from the csharp-mgmt block and hardcode the C# service directory into emitter-output-dir (matching the pattern used by other migrated mgmt specs, e.g. Advisor).

Paired with the .NET SDK PR: Azure/azure-sdk-for-net (ContainerServiceNodeCustomization).

Remove the invalid 'service-dir' option from the @azure-typespec/http-client-csharp-mgmt
emitter block (its schema sets additionalProperties:false and does not allow service-dir),
and hardcode the C# service directory into emitter-output-dir instead. This unblocks .NET
mgmt SDK generation, which previously failed schema validation and emitted an empty src/.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c6383af8-ec0c-4941-a0b4-e5a5e605d0f6
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added namespace-review-required Namespace review required before merge Mgmt This issue is related to a management-plane library. namespace-dotnet-pending labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown

Namespace Review Required

Plane: Management Plane

Language Proposed Namespace Format Status Approvers
dotnet Azure.ResourceManager.ContainerServiceNodeCustomization ⏳ Pending @ArthurMa1978, @m-nash

How to approve:

  • Per language: apply namespace-<language>-approved label
  • All at once: apply namespace-approved-all label (shortcut for mgmt plane)

Merge is blocked until all languages are approved.

Approver list: .github/namespace-approvers.yml
Process: .github/workflows/src/namespace-approval/NAMESPACE-REVIEW-PROCESS.md
Namespaces extracted from tspconfig.yaml emitter options

@github-actions github-actions Bot added resource-manager TypeSpec Authored with TypeSpec labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/containerservicenodecustomization/armcontainerservicenodecustomization
JavaScript @azure/arm-containerservicenodecustomization
C# Azure.ResourceManager.ContainerServiceNodeCustomization
Java com.azure.resourcemanager:azure-resourcemanager-containerservice-nodecustom

Comment generated by After APIView workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Container Service Mgmt This issue is related to a management-plane library. namespace-dotnet-pending namespace-review-required Namespace review required before merge resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant