Fix csharp-mgmt emitter config for ContainerService NodeCustomization#44760
Draft
cxznmhdcxz wants to merge 1 commit into
Draft
Fix csharp-mgmt emitter config for ContainerService NodeCustomization#44760cxznmhdcxz wants to merge 1 commit into
cxznmhdcxz wants to merge 1 commit into
Conversation
Remove the invalid 'service-dir' option from the @azure-typespec/http-client-csharp-mgmt emitter block (its schema sets additionalProperties:false and does not allow service-dir), and hardcode the C# service directory into emitter-output-dir instead. This unblocks .NET mgmt SDK generation, which previously failed schema validation and emitted an empty src/. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c6383af8-ec0c-4941-a0b4-e5a5e605d0f6
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
Namespace Review RequiredPlane: Management Plane
How to approve:
Merge is blocked until all languages are approved. Approver list: .github/namespace-approvers.yml |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews Comment generated by After APIView workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the C# management-plane emitter configuration for the ContainerService NodeCustomization TypeSpec project.
Problem
The
@azure-typespec/http-client-csharp-mgmtemitter block declared aservice-diroption. That emitter's option schema usesadditionalProperties: falseand does not defineservice-dir, so compilation failed with:This silently produced an empty
src/during .NET SDK generation.Fix
Remove the invalid
service-diroption from the csharp-mgmt block and hardcode the C# service directory intoemitter-output-dir(matching the pattern used by other migrated mgmt specs, e.g. Advisor).Paired with the .NET SDK PR: Azure/azure-sdk-for-net (ContainerServiceNodeCustomization).