Skip to content

Prepare specs for C# model naming lint rules#44762

Draft
haiyuazhang wants to merge 3 commits into
Azure:mainfrom
haiyuazhang:haiyzhan/fix-csharp-model-naming-rules
Draft

Prepare specs for C# model naming lint rules#44762
haiyuazhang wants to merge 3 commits into
Azure:mainfrom
haiyuazhang:haiyzhan/fix-csharp-model-naming-rules

Conversation

@haiyuazhang

@haiyuazhang haiyuazhang commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

Prepares existing TypeSpec specs for Azure/typespec-azure#4867 (csharp-no-options-suffix, csharp-no-request-suffix, csharp-no-response-suffix, and csharp-use-standard-acronyms).

  • Pins @azure-tools/typespec-client-generator-core and @azure-tools/typespec-azure-rulesets to the immutable pkg.pr.new build for Add C# nameing convention linter rules - batch1 typespec-azure#4867 (aec1f704).
  • Adds targeted #suppress directives for existing C# SDK model naming violations.
  • Keeps existing generated SDK API surface unchanged while allowing the new rules to validate future unsuppressed declarations.
  • Does not include generated OpenAPI/JSON changes.

Related RPSaaSMaster spec PR: Azure/azure-rest-api-specs-pr#29532
Related typespec-azure PR: Azure/typespec-azure#4867

Validation

  • git diff --check -- specification
  • git diff --check -- package.json package-lock.json

Suppress existing C# SDK naming-rule violations so Azure/typespec-azure#4867 can validate current specs without changing generated API surface.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 869821a6-1f1a-4777-ab20-d49b8490c93e
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

Pin typespec-client-generator-core and typespec-azure-rulesets to the immutable Azure/typespec-azure#4867 pkg.pr.new build so TypeSpec validation exercises the new C# naming rules.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 869821a6-1f1a-4777-ab20-d49b8490c93e

@TimLovellSmith TimLovellSmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign off redis changes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c0af1189-afe1-444d-9911-3e98e456f3b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants