Skip to content

Sync .github/skills directory with azure-sdk-tools for PR 16380#44771

Open
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sync-.github-skills-fix/vally-skill-eval-environment-skills-16380
Open

Sync .github/skills directory with azure-sdk-tools for PR 16380#44771
azure-sdk-automation[bot] wants to merge 5 commits into
mainfrom
sync-.github-skills-fix/vally-skill-eval-environment-skills-16380

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16380 See eng/common workflow

helen229 and others added 5 commits July 17, 2026 18:52
Wires environment.skills: [<skill dirs>] into the mock workflow eval YAML specs so Vally loads the relevant skill per-eval instead of relying on --skill-dir at the pipeline level.
- Add missing environment.skills block to sdk-local-update-metadata-001
  (all other positive stimuli in this file already had it)
- Replace ambiguous/fictional 'contoso' package paths with the real
  fixture package (sdk/compute/azure-mgmt-compute, azure-resourcemanager-compute)
  so the model doesn't need to ask for clarification on a made-up path
- Add explicit version/release-type/date to the version-update stimuli
  since the tool genuinely requires that info

Verified locally: suite score went from ~42% to consistently 83-92%
across repeated runs (threshold 80%).
The trigger.eval.yaml suite reproducibly failed at ~70%% because vague/
informational prompts (SDK release checklist, walk me through the
release process, how to publish a new SDK version, release a new
version of azure-sdk) weren't covered by the skill's narrow trigger
phrase list, so the model didn't reliably invoke the skill.

Added those phrasings to the description, Triggers section, and
Examples, and clarified that the skill should also handle how-to/
checklist style questions, not just direct action requests.

Verified locally: trigger.eval.yaml went from 70%% to 100%% across two
repeated runs (threshold 80%%).
Per Copilot PR review feedback: anti-trigger and negative stimuli in
these eval specs didn't set environment.skills, so the skill was never
loaded/available for those prompts. That made the disallowed
skill-invocation / tool-calls grader checks trivially true (the skill
literally couldn't be invoked), providing no real signal.

Added environment.skills: [..] to all anti-trigger/negative stimuli in:
- azsdk-common-apiview-feedback-resolution/evals/trigger.eval.yaml
- azsdk-common-pipeline-fixer/evals/trigger.eval.yaml
- azsdk-common-pipeline-analysis/evals/trigger.eval.yaml
- azsdk-common-prepare-release-plan/evals/trigger.eval.yaml
- azsdk-common-sdk-release/evals/trigger.eval.yaml
- azsdk-common-generate-sdk-locally/evals/eval.yaml (sdk-local-negative-001)

Verified locally: all 6 suites still pass with the skill loaded and
available - the model correctly declines to invoke it on out-of-scope
prompts. No new failures introduced (5 trigger suites at 100%,
generate-sdk-locally-eval at 91.7%, same pre-existing unrelated failure
as before on sdk-local-analyzer-errors-001).
@azure-sdk-automation
azure-sdk-automation Bot requested a review from helen229 July 17, 2026 19:16
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Jul 17, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 17, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for your contribution @azure-sdk-automation[bot]! We will review the pull request and get back to you soon.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 10 pipeline(s).
6 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. customer-reported Issues that are reported by GitHub users external to the Azure organization. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants