Skip to content

Conversation

@kamil-di
Copy link

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings September 19, 2025 07:45
@kamil-di kamil-di requested review from a team, axisc, hmlam and sjkwak as code owners September 19, 2025 07:45
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs labels Sep 19, 2025
@github-actions
Copy link
Contributor

Thank you for your contribution @kamil-di! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the blob checkpoint store where offset assignment logic was missing or incomplete, ensuring that checkpoint offset values are properly handled when updating checkpoints in blob storage.

  • Fixed missing offset assignment logic to handle both string and numeric offset values
  • Added proper null/empty string validation for offset values
  • Ensured metadata is correctly populated with offset information

Comment on lines 270 to 271
metadata.put(SEQUENCE_NUMBER, sequenceNumber);
metadata.put(OFFSET, checkpoint.getOffsetString());
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are duplicate assignments to the metadata map. Lines 268 and 270 both put SEQUENCE_NUMBER, and lines 269 and 271 both put OFFSET. The second assignments (lines 270-271) will overwrite the first ones, making the new offset logic ineffective. Lines 270-271 should be removed.

Suggested change
metadata.put(SEQUENCE_NUMBER, sequenceNumber);
metadata.put(OFFSET, checkpoint.getOffsetString());

Copilot uses AI. Check for mistakes.
@kamil-di kamil-di force-pushed the patch-1 branch 2 times, most recently from 8cfbc83 to 8a1afbf Compare October 2, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant