changeToUseChangeFeedToFetchPkRanges #46810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the partition key range fetching mechanism by switching from regular queries to change feed queries, improving diagnostics tracking, and modifying retry policy application.
Key changes:
- Switch to change feed approach for fetching partition key ranges to enable incremental updates
- Fix incorrect end time tracking in CosmosDiagnostics for PARTITION_KEY_RANGE_LOOK_UP operations
- Apply throttling retry policy per page instead of across all pages
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| InMemoryCollectionRoutingMap.java | Added change feed continuation token support and logging |
| CollectionRoutingMap.java | Extended interface to support change feed continuation tokens |
| RxPartitionKeyRangeCache.java | Refactored to use change feed for partition key range fetching with proper diagnostics timing |
| RxDocumentClientImpl.java | Modified to support change feed headers and per-request retry policy |
| Paginator.java | Added change feed flag parameter |
| DocumentProducer.java | Updated method call to include change feed flag |
| DefaultDocumentQueryExecutionContext.java | Updated method call to include change feed flag |
| Multiple test files | Updated method signatures and test data to accommodate new parameters |
...smos/src/main/java/com/azure/cosmos/implementation/routing/InMemoryCollectionRoutingMap.java
Outdated
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Outdated
Show resolved
Hide resolved
…ntation/routing/InMemoryCollectionRoutingMap.java Co-authored-by: Copilot <[email protected]>
…ntation/caches/RxPartitionKeyRangeCache.java Co-authored-by: Copilot <[email protected]>
xinlian12
force-pushed
the
useChangeFeedToGetPkRanges
branch
from
e2eaac0 to
ee9cba9
Compare
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...smos/src/main/java/com/azure/cosmos/implementation/routing/InMemoryCollectionRoutingMap.java
Show resolved
Hide resolved
jeet1995
reviewed
Sep 24, 2025
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...re-cosmos/src/main/java/com/azure/cosmos/implementation/caches/RxPartitionKeyRangeCache.java
Show resolved
Hide resolved
...zure-cosmos/src/main/java/com/azure/cosmos/implementation/InCompleteRoutingMapException.java
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/caches/InCompleteRoutingMapRetryPolicy.java
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
requested changes
Oct 21, 2025
Member
FabianMeiswinkel
left a comment
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
LGTM now with the validation of incomplete routng maps - Thin Client team by the way found an instance where container returned incomplete routing map last week - so, definitely worth the effort! Have a few comments around logging and reason for blockign is that I don't understand why failure would map to 404 (vs. 503)
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included: