JS-specific changes for cspell upgrade #36310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
benbp,
mikeharder and
weshaggard
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the spell-check-public-api.ps1 script to change how files are collected and passed to the spell checker. Instead of using glob patterns, the script now resolves actual file paths before passing them to the Invoke-Cspell.ps1 script.
- Changes variable name from
$scanGlobsto$filePaths - Uses
Get-ChildItemto resolve actual file paths instead of constructing glob patterns - Updates the parameter name when calling Invoke-Cspell.ps1 from
-ScanGlobsto-FileList
weshaggard
reviewed
Oct 29, 2025
|
Failure is expected. This PR needs changes in eng/common to merge |
rads-1996
pushed a commit
to rads-1996/azure-sdk-for-js
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.