-
Notifications
You must be signed in to change notification settings - Fork 3.1k
update SDK with Taxonomy #42582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update SDK with Taxonomy #42582
Conversation
Thank you for your contribution @Rimen611! We will review the pull request and get back to you soon. |
@Rimen611 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
2 similar comments
@Rimen611 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@Rimen611 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure AI evaluation SDK to support red teaming with taxonomy input. The changes involve removing deprecated evaluation results operations, updating model configurations, and introducing new taxonomy-related classes.
Key changes include:
- Removal of EvaluationResultsOperations from both sync and async clients
- Addition of new model classes for taxonomy support (Taxonomy, TargetConfig, ModelResponseGenerationTarget)
- Updates to configuration and validation logic for better API version handling
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
operations/__init__.py |
Removes EvaluationResultsOperations import and export |
models/_enums.py |
Removes unused enums and adds EvaluationTargetType |
models/__init__.py |
Updates model imports to support taxonomy functionality |
aio/operations/__init__.py |
Removes async EvaluationResultsOperations |
aio/_configuration.py |
Updates documentation format and SDK moniker |
aio/_client.py |
Removes evaluation_results operations from async client |
_validation.py |
Improves API version comparison logic |
_utils/model_base.py |
Updates failsafe deserialization to use HttpResponse |
_configuration.py |
Updates documentation format and SDK moniker |
_client.py |
Removes evaluation_results operations from sync client |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
def _failsafe_deserialize( | ||
deserializer: typing.Any, | ||
value: typing.Any, | ||
response: HttpResponse, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter name change from 'value' to 'response' creates a breaking change in the function signature. The function is called with 'response.json()' on line 950, but the parameter expects an HttpResponse object. This inconsistency will cause runtime errors.
Copilot uses AI. Check for mistakes.
def _failsafe_deserialize_xml( | ||
deserializer: typing.Any, | ||
value: typing.Any, | ||
response: HttpResponse, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the previous function, changing the parameter from 'value' to 'response' while calling 'response.text()' on line 963 creates an inconsistent interface. The function expects an HttpResponse but is being used as if it receives the response content directly.
Copilot uses AI. Check for mistakes.
Description
Update SDK to accept red teaming with taxonomy input