Fix bug with container name with spaces #42608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tvaron3/readMyWrite
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where containers with spaces or special characters in their names would incorrectly fall back to eventual consistency instead of using session consistency. The issue occurred because container names were stored without URL encoding in the session container, but were passed URL-encoded when retrieving session tokens.
- Added URL decoding of container paths before session token retrieval
- Added test cases to verify session consistency works with special characters in container names
- Updated import statements to improve organization
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
azure/cosmos/_base.py |
Added URL decoding of paths before session token retrieval to fix the core bug |
tests/test_session.py |
Added synchronous test case for containers with spaces in names |
tests/test_session_async.py |
Added asynchronous test case and reorganized imports |
tests/test_crud_async.py |
Added proper async context manager setup |
CHANGELOG.md |
Documented the bug fix |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simorenoh
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our tests were flaky with what seemed like we couldn't read our own write using session consistency. There was a bug where a container named with spaces and other special characters would fall back to eventual consistency because the session container would store container names without url encoding but the container name that is passed in to the session container to set the session token is url encoded.