Skip to content

Conversation

@scbedd
Copy link
Member

@scbedd scbedd commented Dec 13, 2025

See title!

Copilot AI review requested due to automatic review settings December 13, 2025 00:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functionality to generate and publish placeholder packages to PyPI for name reservation purposes. The implementation includes a Python script to generate minimal distribution packages, an entry point for command-line access, and Azure DevOps pipeline templates to build and publish these packages.

Key Changes:

  • New Python tool generate_namereserve_package to create minimal PyPI packages for name reservation
  • Azure DevOps pipeline templates for building and publishing name reservation packages
  • Entry point configuration in pyproject.toml (with perfstress commands reordered)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
eng/tools/azure-sdk-tools/pyproject.toml Added generate_namereserve_package entry point and reordered perfstress commands
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py New Python script to generate placeholder packages with minimal metadata for PyPI name reservation
eng/pipelines/templates/stages/publish-namereserve-package.yml New pipeline template for building and publishing name reservation packages (includes commented ESRP integration)
eng/pipelines/templates/jobs/build-namereserve-package.yml New job template for building name reservation package artifacts
Comments suppressed due to low confidence (1)

eng/pipelines/templates/stages/publish-namereserve-package.yml:73

  • The commented ESRP task references undefined variables ${{parameters.ArtifactName}} and ${{artifact.name}} on line 73. These parameters don't exist in this template's parameter list (only NameForReservation and VersionForReservation are defined). This will cause errors when the task is uncommented. Based on the context, the FolderLocation should likely reference the corrected esrp directory path and use ${{parameters.NameForReservation}} instead.

Copy link
Member

@l0lawrence l0lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I understand lgtm, is this triggered in CI when a new package gets merged to main?

Copy link
Member

@JennyPng JennyPng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😃

@scbedd scbedd merged commit e0b3863 into main Dec 16, 2025
20 checks passed
@scbedd scbedd deleted the add-namereserve-build branch December 16, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants