-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add NameReserve Build #44419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NameReserve Build #44419
Conversation
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds functionality to generate and publish placeholder packages to PyPI for name reservation purposes. The implementation includes a Python script to generate minimal distribution packages, an entry point for command-line access, and Azure DevOps pipeline templates to build and publish these packages.
Key Changes:
- New Python tool
generate_namereserve_packageto create minimal PyPI packages for name reservation - Azure DevOps pipeline templates for building and publishing name reservation packages
- Entry point configuration in
pyproject.toml(with perfstress commands reordered)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
eng/tools/azure-sdk-tools/pyproject.toml |
Added generate_namereserve_package entry point and reordered perfstress commands |
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py |
New Python script to generate placeholder packages with minimal metadata for PyPI name reservation |
eng/pipelines/templates/stages/publish-namereserve-package.yml |
New pipeline template for building and publishing name reservation packages (includes commented ESRP integration) |
eng/pipelines/templates/jobs/build-namereserve-package.yml |
New job template for building name reservation package artifacts |
Comments suppressed due to low confidence (1)
eng/pipelines/templates/stages/publish-namereserve-package.yml:73
- The commented ESRP task references undefined variables
${{parameters.ArtifactName}}and${{artifact.name}}on line 73. These parameters don't exist in this template's parameter list (onlyNameForReservationandVersionForReservationare defined). This will cause errors when the task is uncommented. Based on the context, the FolderLocation should likely reference the corrected esrp directory path and use${{parameters.NameForReservation}}instead.
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Outdated
Show resolved
Hide resolved
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Outdated
Show resolved
Hide resolved
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Outdated
Show resolved
Hide resolved
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Outdated
Show resolved
Hide resolved
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Show resolved
Hide resolved
l0lawrence
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from what I understand lgtm, is this triggered in CI when a new package gets merged to main?
eng/tools/azure-sdk-tools/packaging_tools/generate_namereserve_package.py
Outdated
Show resolved
Hide resolved
JennyPng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 😃
See title!