Fix flaky storage tests#47987
Merged
Merged
Conversation
rads-1996
force-pushed
the
fix-storage-tests
branch
2 times, most recently
from
July 10, 2026 16:22
8237227 to
4ed10b0
Compare
rads-1996
force-pushed
the
fix-storage-tests
branch
from
July 10, 2026 18:59
1a90dc1 to
f97b9cd
Compare
rads-1996
marked this pull request as ready for review
July 10, 2026 19:26
rads-1996
requested review from
JacksonWeber,
MSNev,
hectorhdzg,
jeremydvoss and
lzchen
as code owners
July 10, 2026 19:26
Contributor
There was a problem hiding this comment.
Pull request overview
Enables and stabilizes storage tests through per-test temporary-directory isolation.
Changes:
- Creates and removes a unique temporary directory per test.
- Re-enables
test_storage.py. - Removes lease timing from the storage-size test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/test_storage.py |
Isolates filesystem state and removes lease-related timing. |
tests/conftest.py |
Re-enables storage test collection. |
JacksonWeber
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.