[AutoPR azure-contoso-widgetmanager]-generated-from-SDK Generation - Python-6583934

[azure-sdk-automation]

Configurations: 'specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml', API Version: 2022-11-01-preview, SDK Release Type: beta, and CommitSHA: '1566a98e9251bc95d205802c2379a01b5779e9c8' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6583934 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35101 Submitted by: gaoh@microsoft.com

[Copilot]

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

[Copilot]

Copilot can't review bot-authored pull requests automatically. A user with Copilot access can request a review manually.

[Copilot]

Pull request overview

Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (6)

sdk/contosowidgetmanager/azure-contoso-widgetmanager/tsp-location.yaml:1

• additionalDirectories is not valid YAML as written: the list item is not indented under the key, and the key line has a trailing space. This will likely parse as additionalDirectories: null plus a separate top-level list entry, breaking tooling that reads this file. Indent the list under the key (and remove trailing whitespace) so the YAML structure is correct.
  sdk/contosowidgetmanager/azure-contoso-widgetmanager/generated_tests/test_widget_manager_widgets_operations.py:1
• Importing testpreparer as a top-level module is fragile when running pytest from the repo/package root (it may not be on sys.path). Use a package-relative import (e.g., from .testpreparer import ...) to ensure tests import reliably in CI and local runs.
  sdk/contosowidgetmanager/azure-contoso-widgetmanager/generated_tests/test_widget_manager_widgets_operations_async.py:1
• Same issue as the sync tests: these imports assume the current working directory/layout puts generated_tests on sys.path. Switch to relative imports (e.g., from .testpreparer import ..., from .testpreparer_async import ...) for predictable test execution.
  sdk/contosowidgetmanager/azure-contoso-widgetmanager/generated_tests/conftest.py:1
• These sanitizers pass environment values directly as regex patterns. If any value contains regex metacharacters, sanitization can fail (or over-match unintended content). Escape the values before using them as regex patterns (e.g., via re.escape(...)) so recordings are consistently sanitized.
  sdk/contosowidgetmanager/azure-contoso-widgetmanager/generated_samples/widgets_get_widget_operation_status_sample.py:1
• Correct the typo in the sample value: 'opreation' -> 'operation'. Also consider avoiding spaces in an ID example to reduce the chance of users copying an invalid value.
  sdk/contosowidgetmanager/azure-contoso-widgetmanager/azure/contoso/widgetmanager/types.py:1
• The TypedDict docstring documents created_at, but the actual key is createdAt. Similar snake_case vs camelCase mismatches appear in WidgetSuite as well. This is misleading for users and type checkers—either update the docstrings to match the actual keys, or add documented aliases if the intent is to support snake_case keys in the TypedDict.