PerfTest prototype #2687
Draft
PerfTest prototype #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use built-in `cargo bench` benchmarks for various reasons including they are only supported in `nightly`. But we also want to allow `criterion` to work, so we can define our own test harness (our own main). I think we do something similar to `TestContext` in `azure_core_test` and reuse as much code as possible to support live test resources i.e., requiring provisioned resources and a `.env` file. We define a proc macro to drive it, such that we just add it to an async function returning an `azure_core::Result<()>`. If the .env file is not found, we should exit without error: there's nothing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use built-in
cargo benchbenchmarks for various reasons including they are only supported innightly. But we also want to allowcriterionto work, so we can define our own test harness (our own main).I think we do something similar to
TestContextinazure_core_testand reuse as much code as possible to support live test resources i.e., requiring provisioned resources and a.envfile. We define a proc macro to drive it, such that we just add it to an async function returning anazure_core::Result<()>. If the .env file is not found, we should exit without error: there's nothing to do.