Add append_path() for Url #3161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antkmsft
requested review from
LarryOsterman,
RickWinter,
heaths and
ronniegeraghty
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new append_path() method to the Url type through an extension trait, providing a convenient way to append path segments to URLs while handling slash normalization and preserving query parameters.
- Introduces
UrlExttrait withappend_path()method for intelligent URL path manipulation - Implements slash handling logic to avoid double slashes or missing separators
- Adds comprehensive test coverage for various URL and path combinations
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
heaths
requested changes
Oct 10, 2025
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
Co-authored-by: Heath Stewart <[email protected]>
heaths
requested changes
Oct 14, 2025
RickWinter
reviewed
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage in codegen: https://github.com/Azure/typespec-rust/pull/635