-
Notifications
You must be signed in to change notification settings - Fork 254
Build libuv using the same CMake machinery as other dependencies #568
base: master
Are you sure you want to change the base?
Conversation
|
I've updated the build for Windows and Linux too. I've confirmed that all platforms build successfully with their build scripts (build.sh or build.cmd), and that |
|
I pushed a few more commits:
NOTE on macOS I had to upgrade XCode developer command line tools in order to get past a weird CMake error. I did |
| The sample code and dependancies gets build by running: | ||
| ``` | ||
| tools\build.sh --enable-dotnet-core-binding --disable-native-remote-modules | ||
| tools\build.sh --enable-dotnet-core-binding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop the --enable-dotnet-core-binding here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sample (dotnet_core_dynamic_add_module) is specifically about the .NET Core binding, so I think it's correct as-is.
These changes are incomplete--they work on macOS but I haven't added support yet for Linux or Windows (unfortunately the build instructions for libuv are a little different on each platform). But a related conversation came up in #280, so I'll post this now for people to look at.