Escape double quotes in connection string - #230
Merged
Conversation
Z (zijchen)
requested review from
Chris LaFreniere (chlafreniere),
Drew Skwiers-Koballa (dzsquared) and
Davide Mauri (yorek)
as code owners
June 25, 2024 16:09
Z (zijchen)
temporarily deployed
to
Automation test
June 25, 2024 16:09 — with 
GitHub Actions
Inactive
Z (zijchen)
temporarily deployed
to
Automation test
June 25, 2024 16:09 — with
GitHub Actions
Inactive
Leila Lali (llali)
previously approved these changes
Jun 26, 2024
Drew Skwiers-Koballa (dzsquared)
previously approved these changes
Jun 26, 2024
| /** | ||
| * Returns the connection string escaped by double quotes. | ||
| */ | ||
| public get EscapedConnectionString() : string { |
Contributor
There was a problem hiding this comment.
Can we do effectively the same thing with _parsedConnectionString and iterate through keys/values so that we don't need to parse a second time?
Contributor
Author
There was a problem hiding this comment.
I did think about that but the issue with the key/value pair is the keys may have changed (e.g. Server becomes 'data source') and we'd still need to escape each value again. Since the full connection string is only used by sqlpackage, I wanted it to be as close to the one user supplied without changing it too much.
Contributor
There was a problem hiding this comment.
Ahh, I see. Ok, I can live with that for sure. Can you put a comment here describing this decision?
Contributor
Author
There was a problem hiding this comment.
Added a comment
Z (zijchen)
dismissed stale reviews from Drew Skwiers-Koballa (dzsquared) and Leila Lali (llali)
via
June 26, 2024 22:35
77bd254
Z (zijchen)
temporarily deployed
to
Automation test
June 26, 2024 22:35 — with
GitHub Actions
Inactive
Z (zijchen)
temporarily deployed
to
Automation test
June 26, 2024 22:35 — with
GitHub Actions
Inactive
Chris LaFreniere (chlafreniere)
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escape double quotes in connection string when passing to sqlpackage. Fixes #222 and #137